Re: [FFmpeg-devel] [PATCH] gdigrab: Allow capturing a window by its handle

From: Stefano Sabatini <stefasab@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Lena <lena@nihil.gay>,
	Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Subject: Re: [FFmpeg-devel] [PATCH] gdigrab: Allow capturing a window by its handle
Date: Tue, 12 Dec 2023 01:47:13 +0100
Message-ID: <ZXetkdvmZtvTVili@mariano> (raw)
In-Reply-To: <20231211015651.114219-2-lena@nihil.gay>

On date Monday 2023-12-11 02:52:01 +0100, ffmpeg-devel Mailing List wrote:
> x11grab can capture windows by their ID, but gdigrab can only capture windows by their names, internally calling FindWindowW to lookup its handle.
> 
> This patch simply allows the user to specify a window handle directly.
> Signed-off-by: Lena <lena@nihil.gay>
> ---

>  libavdevice/gdigrab.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)

Missing doc/indevs.texi updates.

> diff --git a/libavdevice/gdigrab.c b/libavdevice/gdigrab.c
> index c069232472..05d3c0c929 100644
> --- a/libavdevice/gdigrab.c
> +++ b/libavdevice/gdigrab.c
> @@ -273,9 +273,13 @@ gdigrab_read_header(AVFormatContext *s1)
>          }
>      } else if (!strcmp(filename, "desktop")) {
>          hwnd = NULL;

> +    } else if (!strncmp(filename, "hwnd=", 5)) {
> +        name = filename + 5;
> +        
> +        hwnd = strtol(name, NULL, 0);

This should fail in case the parsing failed, for this you can check
the second argument (see examples in the code).
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".