From: Stefano Sabatini <stefasab@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avfilter/select: initialize prev_selected_n to NAN
Date: Sun, 10 Dec 2023 01:33:13 +0100
Message-ID: <ZXUHSVs7YFPTqf3r@mariano> (raw)
In-Reply-To: <20231208073543.1907-1-ffmpeg@gyani.pro>
On date Friday 2023-12-08 13:05:43 +0530, Gyan Doshi wrote:
> As per the doc, prev_selected_n should be NAN at the start.
> However, this was never set.
> ---
> libavfilter/f_select.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/libavfilter/f_select.c b/libavfilter/f_select.c
> index 47e36f0014..109dae403a 100644
> --- a/libavfilter/f_select.c
> +++ b/libavfilter/f_select.c
> @@ -230,6 +230,7 @@ static int config_input(AVFilterLink *inlink)
>
> select->var_values[VAR_N] = 0.0;
> select->var_values[VAR_SELECTED_N] = 0.0;
> + select->var_values[VAR_PREV_SELECTED_N] = NAN;
Should be good but move it closer to the other VAR_PREV_* definitions.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-12-10 0:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-08 7:35 Gyan Doshi
2023-12-10 0:33 ` Stefano Sabatini [this message]
2023-12-10 4:01 ` Gyan Doshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXUHSVs7YFPTqf3r@mariano \
--to=stefasab@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git