From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 82DA746D5E for ; Sun, 10 Dec 2023 00:29:07 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DF72468D0A0; Sun, 10 Dec 2023 02:29:04 +0200 (EET) Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9AF3868D022 for ; Sun, 10 Dec 2023 02:28:58 +0200 (EET) Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-40c41df5577so3723725e9.0 for ; Sat, 09 Dec 2023 16:28:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702168137; x=1702772937; darn=ffmpeg.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=uKwybZoEKPQ6e71wBKQXyKu1zHYlQxWKDw68SCaEQ8k=; b=frSLTFNX3nvXVadedaHPzo14GAGJhlaA2LojehKXWeNkthzkMRRPVg1tdGRyuFShTX dpZiTblN640HpE3e0Ydxg+SjmnRYpKK8wDRA2ICxgg8LCoQMApGko1GbNFPK4tA02d2O roA3jyosTHIKAMowAfy1/Ui9c/xPLmPQhY8N0C/7TyXLeEn8+GCLDX2j7y2YNhce98/S X3xy4KXm96mjgbJP70vjPUt/Vq6jJBD0rLCdgDgVS6z7FuW3K1WqJZry9NrVakPcuk0F tvGljVN+Q+56YH5izccgI/CnwQpKoQPfLaCVX7G86ujOD6+HNkgTSnnp3UVavbfVigJr f08Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702168137; x=1702772937; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uKwybZoEKPQ6e71wBKQXyKu1zHYlQxWKDw68SCaEQ8k=; b=tbxrLPlAK5gZFLNtInhfS8CdowfvyEXh0hK42Lc9EhZM8ynKYMVc7r0rn8UsHlSOPn N2zHsJti+r8NPAOBA4s4Hp5maZa396detePfIceC5tCYjlz6Nf2Qae6N194dTW6H0bCV 5Zj9aUrG+XmRDy5wriP8JKYrDI86Kf8x9+MGXLOVumowbsDnZeN4zTOKwQBwjtK8EJsh nBQqmWod1JfPuTPuQj4NcyhjyjQXLT59LUHkcMk03VRVVVoepUbODNW3Yq3ROY54v9JZ 6rx7w/aGT6HtswkGnoAfy/bZxOPnLTmxxTha1BQUKlt6RNZMIX3gQf6FK6lE6twWDj+c KajA== X-Gm-Message-State: AOJu0YzMru7C4iKIT2mD36cBxhQi9DkByyvs/7ZVaiPsNe87vctZsNsv rlqjp8d8i+hxETgsThlp2mC/NO+JfZ4= X-Google-Smtp-Source: AGHT+IE75iWvjDdYTrAa4u5pTcP8BicETvQ2NBNXhn93ibxP24GpTApx5UsRcRcFf59mpXKw2QHvgQ== X-Received: by 2002:a05:600c:158c:b0:40c:2597:1e63 with SMTP id r12-20020a05600c158c00b0040c25971e63mr595391wmf.102.1702168136722; Sat, 09 Dec 2023 16:28:56 -0800 (PST) Received: from mariano (dynamic-adsl-84-220-189-10.clienti.tiscali.it. [84.220.189.10]) by smtp.gmail.com with ESMTPSA id g17-20020a05600c311100b0040c4535f1a2sm37379wmo.39.2023.12.09.16.28.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Dec 2023 16:28:56 -0800 (PST) Received: by mariano (Postfix, from userid 1000) id BA349BFCDA; Sun, 10 Dec 2023 01:28:53 +0100 (CET) Date: Sun, 10 Dec 2023 01:28:53 +0100 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches , Kyle Swanson , Nil Fons Miret References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.1.4 (2021-12-11) Subject: Re: [FFmpeg-devel] [PATCH] doc/filters: expand documentation on libvmaf filter X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Nil Fons Miret , Kyle Swanson Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Friday 2023-12-08 18:47:28 +0000, ffmpeg-devel Mailing List wrote: > Attached. > From e2b98c2dec1248f5000a9291bd6f1177de2a4d0f Mon Sep 17 00:00:00 2001 > From: nilfm > Date: Fri, 8 Dec 2023 14:28:12 +0000 > Subject: [PATCH] doc/filters: expand documentation on libvmaf filter > > Signed-off-by: nilfm > --- > doc/filters.texi | 26 ++++++++++++++++++++------ > 1 file changed, 20 insertions(+), 6 deletions(-) > > diff --git a/doc/filters.texi b/doc/filters.texi > index 6d00ba2c3f..232bd6405b 100644 > --- a/doc/filters.texi > +++ b/doc/filters.texi > @@ -16929,19 +16929,33 @@ The first input is the distorted video, and the second input is the reference vi > > The obtained VMAF score is printed through the logging system. > > -It requires Netflix's vmaf library (libvmaf) as a pre-requisite. > +It requires Netflix's VMAF library (libvmaf) as a pre-requisite. > After installing the library it can be enabled using: > @code{./configure --enable-libvmaf}. > > -The filter has following options: > +The filter has the following options: > > @table @option > @item model > -A `|` delimited list of vmaf models. Each model can be configured with a number of parameters. > +A `|` delimited list of VMAF models. Each model can be configured with the following parameters: This is still ambiguous since it is not defining how the parameters must be specified. IIUC it should be: Each model can be configured with a sequence of key=value parameters, separated by @code{:}. Note that the @code{:} characters is special and needs to be escaped. The following parameters are supported: [...] While at it, it might be good to extend the options with a "models" alias to clarify plurality. > +@table @option > +@item version > +Built-in model version. Example: @code{vmaf_v0.6.1}. > +@item name > +Name that will be associated with this model in the output logs. > +@item path > +Path to a model in the local filesystem. > +@item enable_transform > +If true, a model-defined transform will be applied to the final score. Default value: @code{false}. > +@item disable_clip > +If true, model-defined score clipping will be disabled. Default value: @code{false}. > +@end table > Default value: @code{"version=vmaf_v0.6.1"} > > @item feature > -A `|` delimited list of features. Each feature can be configured with a number of parameters. > +A `|` delimited list of features. Each feature can be configured with a number > +of parameters. The parameter @code{name} should be set to the name of the > +feature. Other key-value parameter pairs will be passed in to the feature extractor. ditto > > @item log_path > Set the file path to be used to store log files. > @@ -16982,9 +16996,9 @@ ffmpeg -i distorted.mpg -i reference.mpg -lavfi libvmaf='model=version=vmaf_v0.6 > @end example > > @item > -Example with multiple additional features: > +Example with multiple additional features and feature options: > @example > -ffmpeg -i distorted.mpg -i reference.mpg -lavfi libvmaf='feature=name=psnr|name=ciede' -f null - > +ffmpeg -i distorted.mpg -i reference.mpg -lavfi libvmaf='feature=name=psnr\\:enable_mse=true|name=ciede' -f null - > @end example looks good otherwise _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".