From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1D19C47CEF for ; Sun, 17 Dec 2023 18:18:33 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6B3BC68D177; Sun, 17 Dec 2023 20:18:32 +0200 (EET) Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id AB6D868D00D for ; Sun, 17 Dec 2023 20:18:25 +0200 (EET) Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-a2335d81693so139244266b.0 for ; Sun, 17 Dec 2023 10:18:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702837104; x=1703441904; darn=ffmpeg.org; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=T5K5orEsjWksGGCjA34unOhscwUGnvP3vxYqMLSSRls=; b=P+n8tiDxkdKcCltc7Q3c9Nu5kQ9l/rlodzN9JzJlZGTvf0+yA4iM4LCuLAHhyUzcZC VgzWlzPv49RwPcSOeVzX8a81zNdUL5L6xxPNVaHebfSkwtlXRAYkSAdtanSB7qod/3Rd 1JcBxaGMomBYUQyUmFjpizt6SzoQmgUfzrr5eHFCogvNOQiTQCrhn5Uz44SBv44UyXrY Ue5IoKUzE1s2oSR1IvHEaYGolyFvGUKAvjgjBBQgcg90GXpJsm6fb+aLq4dtwMOCLHEZ URVz4sPEBJMcbA8VH/rigy4B6l1CEGA9XgcfrEnHlbGOMMtJnmdc2OWJr42kt71RuIQL +4hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702837104; x=1703441904; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=T5K5orEsjWksGGCjA34unOhscwUGnvP3vxYqMLSSRls=; b=BWCikFGhYp9jkaiKPiCMcz6/JzAzpE9IpPJrrY8W/clivd8OCnD8zcNTJb3YOyB9Bu fvhzqVY0sHCSNSKdXwuNmRX1/ic7m0BaKZqReC3KXE2hXtuXPfxBDCXRqaQWPhaw80Pu wA+SvqXTtqkDuqeZxVz9LKcUQmRAQGJmwV4oElwCQw/Mt4BZtF6T3gIpBs69J4yltMDO cz8u7FEL1XsapoDyJw5jEFNiXyjaH+2TegIvnpAlrGsBMk6PSosMmXN860DJTyj5KCK/ txGpyKMrtrHNaVhjftc2uT4fnhjVzMb6kK8aQXk/BJa2YLYwt3/9IdUY3rxK22nr0XmQ i8eQ== X-Gm-Message-State: AOJu0YwO/h6NzolEGumyZ7iHAZaQrlFYiM0Cmeuv/IH1iAHUyIP9G0J5 0/AZ3CX5Z6avYqQU7iNi5L3IJRclcVc= X-Google-Smtp-Source: AGHT+IGquBd1UTIGZgTw6ZSwk5c4rhTcXdF6ozXxED5g+gftbODpGO1MyOq0ayl6hHoKiT+uGy/IRQ== X-Received: by 2002:a17:906:519b:b0:a23:47ce:4a56 with SMTP id y27-20020a170906519b00b00a2347ce4a56mr1128154ejk.40.1702837104006; Sun, 17 Dec 2023 10:18:24 -0800 (PST) Received: from mariano (dynamic-adsl-84-220-189-10.clienti.tiscali.it. [84.220.189.10]) by smtp.gmail.com with ESMTPSA id af2-20020a170906998200b00a2351e4c8e6sm739998ejc.198.2023.12.17.10.18.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Dec 2023 10:18:23 -0800 (PST) Received: by mariano (Postfix, from userid 1000) id 92D4CBFCDC; Sun, 17 Dec 2023 19:18:22 +0100 (CET) Date: Sun, 17 Dec 2023 19:18:22 +0100 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches , =?iso-8859-15?Q?Cl=E9ment_B=BDsch?= References: <20231211014429.1841681-1-u@pkh.me> <20231211014429.1841681-11-u@pkh.me> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231211014429.1841681-11-u@pkh.me> User-Agent: Mutt/2.1.4 (2021-12-11) Subject: Re: [FFmpeg-devel] [PATCH 10/35] avcodec/proresenc_kostya: simplify quantization matrix bytestream writing X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: =?iso-8859-15?Q?Cl=E9ment_B=BDsch?= Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Monday 2023-12-11 02:35:11 +0100, Cl=E9ment B=BDsch wrote: > --- > libavcodec/proresenc_kostya.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > = > diff --git a/libavcodec/proresenc_kostya.c b/libavcodec/proresenc_kostya.c > index 103051830a..e0aa7cf47a 100644 > --- a/libavcodec/proresenc_kostya.c > +++ b/libavcodec/proresenc_kostya.c > @@ -1014,12 +1014,8 @@ static int encode_frame(AVCodecContext *avctx, AVP= acket *pkt, > bytestream_put_byte (&buf, 0); // reserved > if (ctx->quant_sel !=3D QUANT_MAT_DEFAULT) { > bytestream_put_byte (&buf, 0x03); // matrix flags - both m= atrices are present > - // luma quantisation matrix > - for (i =3D 0; i < 64; i++) > - bytestream_put_byte(&buf, ctx->quant_mat[i]); > - // chroma quantisation matrix > - for (i =3D 0; i < 64; i++) > - bytestream_put_byte(&buf, ctx->quant_chroma_mat[i]); > + bytestream_put_buffer(&buf, ctx->quant_mat, 64); // luma = quantisation matrix > + bytestream_put_buffer(&buf, ctx->quant_chroma_mat, 64); // chrom= a quantisation matrix > } else { > bytestream_put_byte (&buf, 0x00); // matrix flags - defaul= t matrices are used > } LGTM. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".