From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id ABFCD472B7 for ; Sun, 3 Dec 2023 21:31:54 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BB76F68CC16; Sun, 3 Dec 2023 23:31:51 +0200 (EET) Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7E60D68BAE0 for ; Sun, 3 Dec 2023 23:31:44 +0200 (EET) Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-a0029289b1bso500658266b.1 for ; Sun, 03 Dec 2023 13:31:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701639103; x=1702243903; darn=ffmpeg.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=9D3z3slKZj2TyGle9SVSk6J3Nc7ZdYqdqVa5ozyO8y8=; b=AeEVMMzWlJP4sqkyYlE/Z6pT0Fr8rasLbT2WsOBZ4+UdFG1nH/+BbT7ebn4Hmrd/dH ecaFXDQvag667j/8H/7RMBN0pqm/pNI3RZX1CgsgiDtjpQyC6mc3NDy0EvFvGRVDY7RZ 7PaNq/y+OrEY0jaoPZOiDB+Ea6rRuscRmIS5m9wsu3fdyRiiu2EBdRKd6N2yt1/lQDLR Vv5sNn6X4QFN+9/z9l/Zz05HAvBALtkGD3q6RYz1Qn2LAmoApnOhEOVbRE9KEj840B4U dqfeaFxAxwu8fXDCXb15QvVHdPC91CTEjM9P3W7HEK8FvuBA7He6ySooK3p8BAXnLLc9 FAWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701639103; x=1702243903; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9D3z3slKZj2TyGle9SVSk6J3Nc7ZdYqdqVa5ozyO8y8=; b=B+eT7/NENDIaPCvotZ2LJ3uKfg3mN6/wjLp2Kx4V83vGoA0q7TMI+k/SKPNXiN/nKW 2x800awFdJiplZKn5bQNbqyFk8tK2STbunOQi0EJSzdG/vSGaz/VngBpr4YlgnUfhipe 75ed/akQU63iCngqJFh5D5j1WoSTu9gr2WhmTQ8zLD3ZKpAKur634wcyhzccsuZ/xLxG amWL6vty8cpleuU5JJ6oJrKpyMKOKnFgwwDQvDQUQ5oUvLzf/8Jz7LCV9O1vZKfMEvc5 Wf3hh4Gyw+E61AkoL4tULBz/aTRbVkzn8UAq2ILrtaX20phXIyHhRbrfJ+1pMyBL+hNA HEoQ== X-Gm-Message-State: AOJu0YzscfvWkp463ENf/LvKD7f1NWI6fRxYQbQd7Yrqui9piYmN9W9/ TtDlnph2sGoxP315lYhJ+AIyn0sO2Uw= X-Google-Smtp-Source: AGHT+IG0l38d/DbyGanis84rxbkpfukkMlkv9n4i+C0+QbUhnaqxTq4nfBNhO6Rp4V4U9mKKsTpvCg== X-Received: by 2002:a17:906:10c:b0:a19:a1ba:8cdf with SMTP id 12-20020a170906010c00b00a19a1ba8cdfmr2595584eje.125.1701639102714; Sun, 03 Dec 2023 13:31:42 -0800 (PST) Received: from mariano (dynamic-adsl-84-220-189-10.clienti.tiscali.it. [84.220.189.10]) by smtp.gmail.com with ESMTPSA id bu23-20020a170906a15700b009fbdacf9363sm4494253ejb.21.2023.12.03.13.31.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Dec 2023 13:31:42 -0800 (PST) Received: by mariano (Postfix, from userid 1000) id 25FBEBFCDA; Sun, 3 Dec 2023 22:31:41 +0100 (CET) Date: Sun, 3 Dec 2023 22:31:41 +0100 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches , Marton Balint References: <20231203002726.29683-1-cus@passwd.hu> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231203002726.29683-1-cus@passwd.hu> User-Agent: Mutt/2.1.4 (2021-12-11) Subject: Re: [FFmpeg-devel] [PATCH 1/7] avutil/tests/imgutils: factorize basic tests to new function X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Marton Balint Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Sunday 2023-12-03 01:27:20 +0100, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > libavutil/tests/imgutils.c | 68 ++++++++++++++++++++++---------------- > 1 file changed, 39 insertions(+), 29 deletions(-) > > diff --git a/libavutil/tests/imgutils.c b/libavutil/tests/imgutils.c > index 748bd6c9d2..f3a433ac4a 100644 > --- a/libavutil/tests/imgutils.c > +++ b/libavutil/tests/imgutils.c > @@ -19,6 +19,41 @@ > #include "libavutil/imgutils.c" > > #undef printf > +static int basic_tests(enum AVPixelFormat pix_fmt, int w, int h) { better be descriptive and follow the usual VERB_OBJECT convention, this might be: static inst check_image_fill(...) [...] LGTM otherwise. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".