From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 0E9A547DC6
	for <ffmpegdev@gitmailbox.com>; Mon, 27 Nov 2023 09:40:29 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C946468CF96;
	Mon, 27 Nov 2023 11:40:26 +0200 (EET)
Received: from nef.ens.fr (nef2.ens.fr [129.199.96.40])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3D30C68CAA4
 for <ffmpeg-devel@ffmpeg.org>; Mon, 27 Nov 2023 11:40:20 +0200 (EET)
X-ENS-nef-client: 129.199.129.80 ( name = phare.normalesup.org )
Received: from phare.normalesup.org (phare.normalesup.org [129.199.129.80])
 by nef.ens.fr (8.14.4/1.01.28121999) with ESMTP id 3AR9eIC0013743
 for <ffmpeg-devel@ffmpeg.org>; Mon, 27 Nov 2023 10:40:18 +0100
Received: by phare.normalesup.org (Postfix, from userid 1001)
 id 687B1EB5BB; Mon, 27 Nov 2023 10:40:18 +0100 (CET)
Date: Mon, 27 Nov 2023 10:40:18 +0100
From: Nicolas George <george@nsup.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Message-ID: <ZWRkAtBcLuvZN/oD@phare.normalesup.org>
References: <20231123191524.11296-2-anton@khirnov.net>
 <20231123191524.11296-4-anton@khirnov.net>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20231123191524.11296-4-anton@khirnov.net>
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3
 (nef.ens.fr [129.199.96.32]); Mon, 27 Nov 2023 10:40:18 +0100 (CET)
Subject: Re: [FFmpeg-devel] [PATCH 02/13] fftools/ffmpeg_filter: make
 sub2video heartbeat more robust
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/ZWRkAtBcLuvZN%2FoD@phare.normalesup.org/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

Anton Khirnov (12023-11-23):
> Avoid making decisions based on current graph input state, which makes
> the output dependent on the order in which the frames from different
> inputs are interleaved.
> 
> Makes the output of fate-filter-overlay-dvdsub-2397 more correct - the
> subtitle appears two frames later, which is closer to its PTS as stored
> in the file.
> ---
>  fftools/ffmpeg_filter.c                   | 3 +--
>  tests/ref/fate/filter-overlay-dvdsub-2397 | 4 ++--
>  tests/ref/fate/sub2video                  | 8 +++++---
>  3 files changed, 8 insertions(+), 7 deletions(-)

Just as I warned you, it breaks the test case I suggested:

./ffmpeg_g -xerror -i /tmp/dummy_with_sub.mkv -preset ultrafast -lavfi '[0:s]setpts=PTS+60/TB[s] ; [0:v][s]overlay' -y /tmp/dummy_with_hardsub.mkv

(/tmp/dummy_with_sub.mkv is created like I told a few days ago)
thousands of frame queued, eventually failing on OOM.

Regards,

-- 
  Nicolas George
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".