From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 471024844A for ; Mon, 4 Dec 2023 15:26:02 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C7F3468CE49; Mon, 4 Dec 2023 17:25:59 +0200 (EET) Received: from nef.ens.fr (nef2.ens.fr [129.199.96.40]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6471268C6D3 for ; Mon, 4 Dec 2023 17:25:53 +0200 (EET) X-ENS-nef-client: 129.199.129.80 ( name = phare.normalesup.org ) Received: from phare.normalesup.org (phare.normalesup.org [129.199.129.80]) by nef.ens.fr (8.14.4/1.01.28121999) with ESMTP id 3B4FPqae017813 for ; Mon, 4 Dec 2023 16:25:52 +0100 Received: by phare.normalesup.org (Postfix, from userid 1001) id 86AB7E6C30; Mon, 4 Dec 2023 16:25:52 +0100 (CET) Date: Mon, 4 Dec 2023 16:25:52 +0100 From: Nicolas George To: FFmpeg development discussions and patches Message-ID: References: <20231130204812.GQ3543730@pb2> <20231201111621.10989-1-anton@khirnov.net> <170144085892.8914.16673285602438268082@lain.khirnov.net> <170144198228.8914.6757885452665407226@lain.khirnov.net> <170144268666.8914.14610541165951753799@lain.khirnov.net> <170146019227.8914.6674790290782283298@lain.khirnov.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <170146019227.8914.6674790290782283298@lain.khirnov.net> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (nef.ens.fr [129.199.96.32]); Mon, 04 Dec 2023 16:25:52 +0100 (CET) Subject: Re: [FFmpeg-devel] [PATCH 13/13 v3] fftools/ffmpeg: convert to a threaded architecture X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Anton Khirnov (12023-12-01): > I can definitely say it is broken and I already told you why. But if you > want something more specific: > * the output of your example with the current master changes depending > on the number of decoder frame threads; my patch fixes that > * in fate-filter-overlay-dvdsub-2397 subtitles appear two frames too > early; again, my patch fixes that Ok, some cases are broken. Fine, this is a hard task, some cases are impossible. That does not allow you to break cases that are currently working. > IIUC your suggestion was to send heartbeat packets from demuxer to > decoder, then have the decoder forward them to filtergraph. > > That is EXACTLY what I'm doing in the final patch, see [1]. It also does > not address this problem at all, because it is caused by the heartbeat > processing code making decisions based on > av_buffersrc_get_nb_failed_requests(), which fundamentally depends on > what frames previously arrived on the video input. Then fix it. I have given you a command that currently works and produces valid output: make sure it still works with your changes. And that will require sending heartbeat frames only when they are needed, keeping the current logic in place. -- Nicolas George _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".