From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id F2E3048072 for ; Thu, 9 Nov 2023 10:47:33 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2DA3C68CB7F; Thu, 9 Nov 2023 12:47:31 +0200 (EET) Received: from nef.ens.fr (nef2.ens.fr [129.199.96.40]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DC43368C8BE for ; Thu, 9 Nov 2023 12:47:24 +0200 (EET) X-ENS-nef-client: 129.199.129.80 ( name = phare.normalesup.org ) Received: from phare.normalesup.org (phare.normalesup.org [129.199.129.80]) by nef.ens.fr (8.14.4/1.01.28121999) with ESMTP id 3A9AlOcV027549 for ; Thu, 9 Nov 2023 11:47:24 +0100 Received: by phare.normalesup.org (Postfix, from userid 1001) id 0A20BEB5BB; Thu, 9 Nov 2023 11:47:23 +0100 (CET) Date: Thu, 9 Nov 2023 11:47:23 +0100 From: Nicolas George To: FFmpeg development discussions and patches Message-ID: References: <20231104092125.10213-1-anton@khirnov.net> <20231104092125.10213-9-anton@khirnov.net> <169952656183.11195.3322106643898810523@lain.khirnov.net> MIME-Version: 1.0 In-Reply-To: <169952656183.11195.3322106643898810523@lain.khirnov.net> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (nef.ens.fr [129.199.96.32]); Thu, 09 Nov 2023 11:47:24 +0100 (CET) Subject: Re: [FFmpeg-devel] [PATCH 08/24] fftools/ffmpeg_filter: remove an unnecessary sub2video_push_ref() call X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============9146201062136305973==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============9146201062136305973== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Bs2j6H7QYTK/tXpu" Content-Disposition: inline --Bs2j6H7QYTK/tXpu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Anton Khirnov (12023-11-09): > The problem with that code (and the reason this patch exists), is that > it depends on the order in which the frames arrive on filtergraph > inputs, which is not meaningful (and becomes non-deterministic with > threading). I can understand that. We will have to find a solution, won't we? (I hope you do not consider removing a feature that people have been using for years an option.) I can suggest this: have demuxer code emit virtual subtitles packets to trigger the sending of the heartbeat frames. Regards, --=20 Nicolas George --Bs2j6H7QYTK/tXpu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE6ooRQGBoNzw0KnwPcZVLI8pNxgwFAmVMuLoACgkQcZVLI8pN xgyNoxAAj34grXMYN5lhEHJV5yBJAPMXRhy1Sy3bUucHv5VJvquy1hd/G3iPV5RQ /kWZFGrv5Cjo4US7bcVr07uY9v/KP6IJFpDJdIUnxlL7EBtuOlxZ1tHDihhSHxAJ gaJkOja++grmbrvS51rkl1w3TUzLEt5I5P+c5VUxHLaHTR5ExjUE1EhKem0oxQLc gGoggBU6bSgzFuqBu9J1vlrH9Sp7ZSFk+/We1N6ENva/9BWrgEsdstKshZFCVq15 AdSPsBVBMALGFlz4frnTEHs4cFEgjqp3pwfZzn3XdODmPtygO9BSf9KlvqfL3llG 0sKUTehNxMF3NsO0NyCUnKhQ6enf130dhr/h8Oaxn/QoJca0duJm2aSx3LtWGwQ0 546KENJ/lWJnacseFL0TVrtyuHn3AH/8vc6w/G4yh0Ga20bwIVa+NXwBdMNd2AG4 UUI/hbTPjaMTh1mjRSxOSPJUTcncGiDrES3C7mXldHG2wHuJC+aQj7mVhG80pnGU 3uq8Wz9PF7GlHBSwAD+tj8GzeY047LCUiTriftxpAGrwteesXXMqHsYS1ulzG4FE HdXXSZCKlFNk6++B5ZsNEOGujQtvyL6iszJmJJSZkLpEBgzHHq00Zbp/Po0LnGtO mCaFVatL9q3BRVYvREAIROWwaVuGIG8v4HgFGNr7iJqPXc9w+7w= =F248 -----END PGP SIGNATURE----- --Bs2j6H7QYTK/tXpu-- --===============9146201062136305973== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============9146201062136305973==--