From: Stefano Sabatini <stefasab@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v2] doc/t2h: Support texinfo 7.0
Date: Wed, 8 Nov 2023 01:15:17 +0100
Message-ID: <ZUrTFeMGtWrkjaTC@mariano> (raw)
In-Reply-To: <C95A5225-1E4E-4C20-9A2E-932DC6FFA359@gmail.com>
On date Tuesday 2023-11-07 23:32:23 +0100, epirat07@gmail.com wrote:
> On 7 Nov 2023, at 22:44, Frank Plowman wrote:
>
> > On 07/11/2023 20:38, epirat07@gmail.com wrote:
[...]
> >> Just had a quick look and was wondering why your patch touches the
> >> bootstrap.min.css?
> >
> > Texinfo 7.0 produces quite different HTML to Texinfo 6.8. Without
> > that change to the CSS, enumerated option flags (i.e. Possible
> > values of x are...) render as white text on a white background
> > with Texinfo 7.0 and are unreadable. The change removes a style
> > for the selector `.table .table` which causes the background to
> > turn white. As far as I can tell, it is not actually used anywhere
> > in files generated by Texinfo 6.8.
> >
>
> Thanks for the clarification, I think it might be a good idea to split this change
> into a second commit with the explanation you gave in the commit message. That way
> if it ever causes an issue, it is easier to figure out, as this minified css is
> nearly unreviewable…
+1
That said, I tested the latest patch and seems to work fine with
texinfo 6.8.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-11-08 0:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-07 15:57 Frank Plowman
2023-11-07 20:38 ` epirat07
2023-11-07 21:44 ` Frank Plowman
2023-11-07 22:32 ` epirat07
2023-11-08 0:15 ` Stefano Sabatini [this message]
2023-11-08 8:03 ` [FFmpeg-devel] [PATCH v3] doc/html: " Frank Plowman
2023-11-08 16:53 ` Frank Plowman
2023-11-08 22:56 ` Stefano Sabatini
2023-11-08 22:59 ` Stefano Sabatini
2023-11-08 23:27 ` Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZUrTFeMGtWrkjaTC@mariano \
--to=stefasab@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git