From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 695E947335 for ; Sat, 4 Nov 2023 21:38:18 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C47C768CE90; Sat, 4 Nov 2023 23:38:15 +0200 (EET) Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6E2DF68CE77 for ; Sat, 4 Nov 2023 23:38:09 +0200 (EET) Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-32df66c691dso1830621f8f.3 for ; Sat, 04 Nov 2023 14:38:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699133888; x=1699738688; darn=ffmpeg.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=3aekN41yIM1gxJHSV9VUmB3Aut+S2uJdRaE/O4/ijKY=; b=f1z0gpl2GRd1gO3CfTJjgJlEmIVO+rNxy+doIbIglD3KiWp0/MdB09irYoBbAZi4y6 2tUrnGBkLZUfvy2f+Kyg32zc9lLWS5wfQt2E/z4uZ2Ih/Jja/fYr+5+BWmSkTGYlGTQO 8kvNF10zT8NObfyvrr9C8qSd7cWjZNyZRX/9ySr98H9wz5iLelPKk+ybChNNDSm9JuO2 Tx20yxNM9kaqjDZDGTRGQNlxaEgkW+A8siMUCXocj6unGBHm4NjxQjE+CVxyoWnQk8G4 mg1cCZsWvVOuNqPc2UOksPMiFAmzCLEOlhLWZuGt60KAZha4tfuT8PiWaj7Kc0gl+y68 brMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699133888; x=1699738688; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=3aekN41yIM1gxJHSV9VUmB3Aut+S2uJdRaE/O4/ijKY=; b=a/Km0c590g3Pm0mp8HXY8+zwC+3vR6OzX6iF/mSE1sAHCPJkI0nJJPO2F+/pn/yx9Q LroZ/GFM3DRRgm2WVRWdUZ5HnJNb6llr8Nl3DeIBysNR8Tyro3SZ3Q89ZMfokz75PJHi 6bIPwp+NhEFKdX30kRv4PTMguDrpw25pc8PW6pMmM+LOqVtTdVxdHRLsj7g90LW5C1hH CNbZB5kycg3vQoBbqLPgYpqlRftnp6mLYanFBzilRcQXQoqaty0Nijyh7T1tG3QeETL6 LZ9hvd+R0PLma/bruwhhw7lqvMgMQuQvWR5fOpTRxl1x2YtEC8QYKZxVgjHilUEBWYKr 3VjA== X-Gm-Message-State: AOJu0YzV/tlujGHNUgdueL7/iNTTbjZCNSDuKLrsKnJJPD4398Ga4VZ/ rnpVoDknmPGP6xKHFV5hdyhGcD3P4Z891A== X-Google-Smtp-Source: AGHT+IGlr8xxeJI28wc6NONLmaPpoHT1l55ZUcqtH5VgnATM7gU+wu76J3oJTgU4YtTFqL1kzBhqkA== X-Received: by 2002:a5d:53c9:0:b0:32d:701b:a585 with SMTP id a9-20020a5d53c9000000b0032d701ba585mr18852582wrw.69.1699133888190; Sat, 04 Nov 2023 14:38:08 -0700 (PDT) Received: from mariano (dynamic-adsl-84-220-189-10.clienti.tiscali.it. [84.220.189.10]) by smtp.gmail.com with ESMTPSA id p14-20020a5d68ce000000b0032daf848f68sm5360110wrw.59.2023.11.04.14.38.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Nov 2023 14:38:07 -0700 (PDT) Received: by mariano (Postfix, from userid 1000) id A2018BFCDA; Sat, 4 Nov 2023 22:38:06 +0100 (CET) Date: Sat, 4 Nov 2023 22:38:06 +0100 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches References: <20230826122328.95416-1-stefasab@gmail.com> <169306293626.20400.4712343328864304301@lain.khirnov.net> <169358345620.20400.6777068619760269139@lain.khirnov.net> <169391274067.20400.12945788077351942626@lain.khirnov.net> <169399880562.20400.15389167820793227268@lain.khirnov.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <169399880562.20400.15389167820793227268@lain.khirnov.net> User-Agent: Mutt/2.1.4 (2021-12-11) Subject: Re: [FFmpeg-devel] [PATCH] lsws/swscale.h: introduce sws_get_gaussian_vec X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Wednesday 2023-09-06 13:13:25 +0200, Anton Khirnov wrote: > Quoting Stefano Sabatini (2023-09-06 00:59:44) [...] > A simple rename is a trivial API change. Almost everything else is not. > > > and therefore should not be committed. > > Yes, the baseline for every API change is that it is undesirable and you > must supply sufficiently strong arguments to overcome that. > > > Also there is no evidence that external components are using this > > function. > > > > Besides the naming change, there are ergonomic and functional changes > > making the behavior of the code more correct. > > I do not see the code being made more correct, but Michael observed in > this thread that it becomes longer and more convoluted. It is a different construct, not necessarily more convoluted. Also keep in mind this is needed in order to achive two goals: 1. return a proper error code since we can have two types of failures here (memalloc or invalid argument) 2. log the invalid argument reason so that the failure reason is in the log, without having to repeat the validation logic in the caller > I am not convinced that adding logging to this function is an > improvement. You have to pass an extra parameter to every call, making > the code longer and less readable. We do not need a dedicated error > message for every malloc. See above, in this case we can have ENOMEM/EINVAL and it should be possible to distinguish between the two. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".