From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 33C0A472B7 for ; Fri, 3 Nov 2023 19:04:28 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 16A7668CD9F; Fri, 3 Nov 2023 21:04:26 +0200 (EET) Received: from nef.ens.fr (nef2.ens.fr [129.199.96.40]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7980068CCEA for ; Fri, 3 Nov 2023 21:04:19 +0200 (EET) X-ENS-nef-client: 129.199.129.80 ( name = phare.normalesup.org ) Received: from phare.normalesup.org (phare.normalesup.org [129.199.129.80]) by nef.ens.fr (8.14.4/1.01.28121999) with ESMTP id 3A3J4IL9014045 for ; Fri, 3 Nov 2023 20:04:18 +0100 Received: by phare.normalesup.org (Postfix, from userid 1001) id A856FE6C30; Fri, 3 Nov 2023 20:04:18 +0100 (CET) Date: Fri, 3 Nov 2023 20:04:18 +0100 From: Nicolas George To: FFmpeg development discussions and patches Message-ID: References: MIME-Version: 1.0 In-Reply-To: X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (nef.ens.fr [129.199.96.32]); Fri, 03 Nov 2023 20:04:19 +0100 (CET) Subject: Re: [FFmpeg-devel] [PATCH] avfillter/buffersrc: activate and EOF fix X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6619562754545731470==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6619562754545731470== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="I/hHOOSCByPJANWu" Content-Disposition: inline --I/hHOOSCByPJANWu Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Tristan Matthews (12023-11-02): > Just to confirm that I can reproduce JEEB's test, before the patches: Just to be clear: I never doubted that Paul's patches do make the bug go away in your test case. That would imply accusing Paul of lying about simple technical facts, that would be both stupid and uncivil. What you need to understand is that is barely relevant: =E2=80=9CI churned = the code a lot and now the bug does not happen in my test case=E2=80=9D is not = an acceptable way of leading development. What Paul needs to provide (or you, or anybody else; no idea who =E2=80=9CJ= EEB=E2=80=9D is) is a proof that the changes are both correct and necessary. Correct: you need to prove that this bug is fixed in all cases, not just the one you were testing on. Necessary: you need to establish that the bug cannot be fixed with fewer changes, because each change is chance for introducing a new bug. Such a proof would certainly start with with an analysis of how the bug gets triggered by the current code. The =E2=80=9Cnecessary=E2=80=9D point is especially important: it is a well= -established principle that filters with no more than one input and one output do not need to use the activate framework directly (and therefore should not, as it makes the code more complex). If Paul thinks he found an exception to that well-established law, he needs to present strong evidence. But if no such exception exist (which is the most likely: the law is true), then it is entirely possible that what Paul found is a bug in the code that implements the activate mechanism for simple filters. And in that case, we need to fix that bug. Or maybe the actual problem is somewhere in the fftools an error check is skipped. We need to know what is happening before any fix can be devised. We need an analysis of the bug. Any effort going into this that is not first analyzing what is going on is a waste of time. Regards, --=20 Nicolas George --I/hHOOSCByPJANWu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE6ooRQGBoNzw0KnwPcZVLI8pNxgwFAmVFRDAACgkQcZVLI8pN xgycFw//bS2FHoeGe6TNjeNKzn2Q+tNK1N57onLLYZLUBgW0Ksm+LSI+6k++4Jwi KXbpHh7fYPP+pKgnodtuJjNZ0IfGidr/UvEbpF8Ncjj4gnESudF6//WaZZcWFTtp U2gg2tcY3i/+VBldSM6DpFrIz32QyQgK0VOYd3ytDQ/ncnrQ4Wl0+a5/qKC9KyiR CafosN2z5g7RNbtzjuI9YG1qPgIdHr4R/1fsRUBNZd0igqtjBa8S/Dg39MHalQ90 6HoHWIGhdfY8U/InOskuHKwgaZ49VRVRkY6cTz8U3FwL+UFTQmtR3QFbvyyhqB2V 38KdcFEFauN5aLm0LZpZd0gxtdeHajzbk1+VJ16g+foVkoMvoTwZyq8ovjZToZm3 qe9JDlp0IXFbTNRuFnDc+iJ1JAcKtQ9VMJ4nIlVcRfYPTHIDEw3N+WqGVaYIxZoq TEVzZJVAS35DSZJJKsX8q3fCONqJGIyWLQ3YLYRGL6O5LfxJX0GtXAYO4PcNKNTD 2SwXTuBJGujg1FP27N/WDEAAlTDQAsbqNKhAIQbxLkKCDhq8O1qfhcYwV3YcVeSQ 5/mHNSyIyLzvm1OsF+UEmGaf7OjfiRJlqKazJQGv7hE4rVssjdY+4CI7BhyvveeD /c6JnUr2yoIiv1bDLfGszN2BMcjJVt8WDaZFgKXauRIgrBHQfoY= =T2c1 -----END PGP SIGNATURE----- --I/hHOOSCByPJANWu-- --===============6619562754545731470== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6619562754545731470==--