From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1424F47F10 for ; Thu, 2 Nov 2023 10:03:15 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2FC1C68CC65; Thu, 2 Nov 2023 12:03:13 +0200 (EET) Received: from nef.ens.fr (nef2.ens.fr [129.199.96.40]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3073A68CC5A for ; Thu, 2 Nov 2023 12:03:06 +0200 (EET) X-ENS-nef-client: 129.199.129.80 ( name = phare.normalesup.org ) Received: from phare.normalesup.org (phare.normalesup.org [129.199.129.80]) by nef.ens.fr (8.14.4/1.01.28121999) with ESMTP id 3A2A35lY021482 for ; Thu, 2 Nov 2023 11:03:05 +0100 Received: by phare.normalesup.org (Postfix, from userid 1001) id 5CBE1EB5B7; Thu, 2 Nov 2023 11:03:05 +0100 (CET) Date: Thu, 2 Nov 2023 11:03:05 +0100 From: Nicolas George To: FFmpeg development discussions and patches Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (nef.ens.fr [129.199.96.32]); Thu, 02 Nov 2023 11:03:05 +0100 (CET) Subject: Re: [FFmpeg-devel] [PATCH] avfillter/buffersrc: activate and EOF fix X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Paul B Mahol (12023-11-02): > I analyzed it already, It is very sorry state of libavfilter that buffersrc > keeps sending frames to EOF filtergraph. So, Paul, I will explain this to you one last time. Remember high school, when you had math test, and if you just gave the result you got almost no points even if the result was correct? That was because solving a math exercise is not just about finding the result, it is about showing how you reach the result and proving that the result is correct. The same goes here. On your own projects, you can change randomly the code until a bug is no longer triggered and call it fixed. But in FFmpeg, you are not alone, and when a change is not trivial you have to prove to your fellow developers that it is correct and necessary. So get to work, produce that proof, re-submit the patch with the proof in the commit message, and then we can talk. As it is, the need to switch buffersrc to activate is not established, and therefore it should not be done. -- Nicolas George _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".