From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C78D147AE6 for ; Wed, 1 Nov 2023 13:57:06 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D280968CD5F; Wed, 1 Nov 2023 15:57:03 +0200 (EET) Received: from nef.ens.fr (nef2.ens.fr [129.199.96.40]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8DA0D68CD1D for ; Wed, 1 Nov 2023 15:56:57 +0200 (EET) X-ENS-nef-client: 129.199.129.80 ( name = phare.normalesup.org ) Received: from phare.normalesup.org (phare.normalesup.org [129.199.129.80]) by nef.ens.fr (8.14.4/1.01.28121999) with ESMTP id 3A1DuukS030101 for ; Wed, 1 Nov 2023 14:56:56 +0100 Received: by phare.normalesup.org (Postfix, from userid 1001) id 8361EE6C30; Wed, 1 Nov 2023 14:56:56 +0100 (CET) Date: Wed, 1 Nov 2023 14:56:56 +0100 From: Nicolas George To: FFmpeg development discussions and patches Message-ID: References: MIME-Version: 1.0 In-Reply-To: X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (nef.ens.fr [129.199.96.32]); Wed, 01 Nov 2023 14:56:56 +0100 (CET) Subject: Re: [FFmpeg-devel] [PATCH] avfillter/buffersrc: activate and EOF fix X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6959737596633896513==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6959737596633896513== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Kpqy36y8yUnpvK42" Content-Disposition: inline --Kpqy36y8yUnpvK42 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Jan Ekstr=C3=B6m (12023-11-01): > So my question is: Does this test case not improve for you after you > have applied these patches? Or are you speaking of a separate problem > which is bad both in master as well as after these patches have been > applied? This is the test case Paul posted yesterday (except you had the politeness to de-script it) and I used to see that it does not fix the issue. Anyway, except in the simplest of cases, if a change does not include an analysis of why the problem happens and how the change prevents it from happening the simplest way, then it is not a bug fix, it is just dumb luck. And most likely, the bug is not really gone, it just shifted to not be triggered by the test case. There is no such analysis in Paul's patches. If he can submit such an analysis these patches can move forward. But based on my knowledge of the activate code (I wrote it=E2=80=A6) I am pretty certain this kind of bug does not need a source with a single output to be switched to activate. Regards, --=20 Nicolas George --Kpqy36y8yUnpvK42 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE6ooRQGBoNzw0KnwPcZVLI8pNxgwFAmVCWSYACgkQcZVLI8pN xgx9+Q//XxKFL16x8YI0+jkteo1pgGwP+gXjDUqIEcUB1yMnQCAN3cTMCv1OpP9V HXWwSXATqoyngSjnlbGJ1naJpnf0ZKZzFWquvT1HzB0Or+o/HS4TUj3lLNYBWYcs EG3aEWnZStN3MBJdJkNjyRs0UP1rU9Kk7dCCt4CvFNTrZcnds4hZCHFbEvCn2WNK 85OlmlrJqcJHzxl4CYxehRM8Dpo7ZzRJr6OH/J2m/Dw3rz1HogiiYMrYPZJhRcPL TIPGEgG9g0T8LFZAW0MBwujxCrh/YhukRx2BhlkSTWgGlt21ga6F/v6tEazQj5RO afNgu3hhsO4phkupO2XCJWKKt8Ulfv/PaB6PbZAaHsJcTQnVqJ67CZHmq5xfbGxw 148n9ht83uR0qXzWyL7uOmZSLCSY4sOkkUbQLWVBg0edd4cqD6mc2OjDuGat3o3u 0IWuBGpYFf4QQt9GBrkOhtrl7TM05uUwWiOlmG7lw4B3U+gseeMTRYoZNTKOegSJ LlJDgDoDcERNB7rn10SIqYYCzn9qt/UeZGzzbDnMgdOCnNwFp5av+fSx0xOZXft8 BMJQva2mj2vY477FkAV1A4tVD0ZsMHcfslnozADbxT9OquLlE6TGjJ9TVqj6RwUT bFCD5J+MDFZ0AvRS29VEvjtZft1Cs7iUkhJpztk6fiUDWx180qw= =o6Y9 -----END PGP SIGNATURE----- --Kpqy36y8yUnpvK42-- --===============6959737596633896513== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6959737596633896513==--