Re: [FFmpeg-devel] [PATCH] avfillter/buffersrc: activate and EOF fix

[Nicolas George <george@nsup.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1058 bytes --]

Jan Ekström (12023-11-01):
> So my question is: Does this test case not improve for you after you
> have applied these patches? Or are you speaking of a separate problem
> which is bad both in master as well as after these patches have been
> applied?

This is the test case Paul posted yesterday (except you had the
politeness to de-script it) and I used to see that it does not fix the
issue.

Anyway, except in the simplest of cases, if a change does not include an
analysis of why the problem happens and how the change prevents it from
happening the simplest way, then it is not a bug fix, it is just dumb
luck. And most likely, the bug is not really gone, it just shifted to
not be triggered by the test case.

There is no such analysis in Paul's patches. If he can submit such an
analysis these patches can move forward. But based on my knowledge of
the activate code (I wrote it…) I am pretty certain this kind of bug
does not need a source with a single output to be switched to activate.

Regards,

-- 
  Nicolas George

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".