From: Nicolas George <george@nsup.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v2] avformat/hls: use av_strlcopy instead of strncpy
Date: Mon, 30 Oct 2023 15:16:27 +0100
Message-ID: <ZT+6u1L4ii+Zc+bX@phare.normalesup.org> (raw)
In-Reply-To: <adb258d6-e240-49d2-b782-25dc43927af5@gmail.com>
Leo Izen (12023-10-30):
> Also, fwiw, info->assoc_language is the name of a language. It shouldn't
> actually ever be 63 characters long for real streams in the wild, and
> truncating it is just a memory-safety precaution. It's not a bug.
It SHOULD not, but it CAN be, and properly reporting the error to the
user is important.
It is just about adding an if and return error.
Regards,
--
Nicolas George
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-10-30 14:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-29 12:47 Leo Izen
2023-10-29 12:49 ` Leo Izen
2023-10-30 0:23 ` Andreas Rheinhardt
2023-10-30 0:33 ` Leo Izen
2023-10-30 7:51 ` Nicolas George
2023-10-30 13:52 ` Leo Izen
2023-10-30 13:55 ` Nicolas George
2023-10-30 14:01 ` Leo Izen
2023-10-30 14:16 ` Nicolas George [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZT+6u1L4ii+Zc+bX@phare.normalesup.org \
--to=george@nsup.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git