From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0D80D47622 for ; Sun, 15 Oct 2023 02:59:24 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D413568BED8; Sun, 15 Oct 2023 05:59:21 +0300 (EEST) Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0E83B68BED8 for ; Sun, 15 Oct 2023 05:59:15 +0300 (EEST) Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-9b2f73e3af3so506030166b.3 for ; Sat, 14 Oct 2023 19:59:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697338754; x=1697943554; darn=ffmpeg.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=GonOHt7ODGyceUcrZSNu/sBBr/7yPB49y/4686mEV2I=; b=hScj0x8g11PeHOTByZ22x/2BawaJXHGLe4xizG+zwspDGG4U6Yl1z7sa9hl5/PYuWn lDRey6RlfYp2La4vlWgzTwUTJDs54qk/2jHyTh+4XfeqsWB/Hr/hbJRy//SoZtnl4jqs oqrrlJY9BSm+X/mxekdJ/4JAeKVT91vKu1iEQsHiQ3kuYWeVZx5Jd332cKv5FOcfEcIL FYuAvjjwMe2PT9fOBcA8OcsTc/vxR1TVRVVBKjo7pcqS9UVDgHalfy7G2DZhzwZ2Y8vT Ij/NVae0dhVIw9IV/rKoKRJxKUNIoweCo5oGREVZVF7er9xj2VTiZRKt5hN1lG98eRZX uEpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697338754; x=1697943554; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=GonOHt7ODGyceUcrZSNu/sBBr/7yPB49y/4686mEV2I=; b=fIgbqvc2SSQ9jjkg//Q923iJoP0Wn734JFYQmsOb0p8vSHKxJiNeBz605EoUwk9M6K G4EFZX9jvthkS8ZZCQrqh+TvkFiNamjwsKSVrE1GjisEw8ba+Lemx+2jf1Yb+xTnuKRD 1/kTSgu5c6ldwDKejh6O4+WLcxZhF/krNGNYijZVXM9d4v9jeXHnNREk4CNkXyPjQz71 s/ywhR8W9eTAmJLx9fQN0l1BXWoSbKu3sS7ILsLWRHOvcD5GgvKX7LgnggYKaONXrHZV wbffBh4DTkcBIgC3AoqfIA1jcJv3Al+a4D8log/rx6+v1biHxG8P8GlTq00gMCm+9TKa ATgg== X-Gm-Message-State: AOJu0YzhrgcDDUJZTXRo4DzYA8dOQUDM3HtiYeLl7yi8zJtyXszpqJv5 zQ1VEvkreo2IKT6KA3XWp4DKfTVCD8RlUw== X-Google-Smtp-Source: AGHT+IERBvpVEofwKopDRA5QlXfDqCWkc5M1hQDl8t//awwULy97Gi7osJTM+CCUNOesSfuWO8WOHQ== X-Received: by 2002:a17:906:1ca:b0:9a5:9f3c:9615 with SMTP id 10-20020a17090601ca00b009a59f3c9615mr23830090ejj.63.1697338753813; Sat, 14 Oct 2023 19:59:13 -0700 (PDT) Received: from mariano (dynamic-adsl-84-220-189-10.clienti.tiscali.it. [84.220.189.10]) by smtp.gmail.com with ESMTPSA id x15-20020a170906710f00b0099bcd1fa5b0sm1681398ejj.192.2023.10.14.19.59.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Oct 2023 19:59:13 -0700 (PDT) Received: by mariano (Postfix, from userid 1000) id 2885EBFCDA; Sun, 15 Oct 2023 04:59:12 +0200 (CEST) Date: Sun, 15 Oct 2023 04:59:12 +0200 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches References: <20231014172428.382368-1-stefasab@gmail.com> <2b2a432b-7b28-4386-b5fe-d60dac09a4a2@rothenpieler.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2b2a432b-7b28-4386-b5fe-d60dac09a4a2@rothenpieler.org> User-Agent: Mutt/2.1.4 (2021-12-11) Subject: Re: [FFmpeg-devel] [PATCH] ffprobe: fix XML rendering, review XML layout X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Sunday 2023-10-15 03:09:14 +0200, Timo Rothenpieler wrote: > On 14.10.2023 19:24, Stefano Sabatini wrote: > > Fix rendering of int values within a side data element, which was > > broken since commit d2d3a83ad93, where the side data element was > > correctly marked as a variable fields element. Logic to render a > > string variable was implemented already, but it was not implemented > > for the int fields path, which was enabled by that commit. > > > > Also, code and schema is changed in order to account for multiple > > variable-fields elements - such as side data, contained within the > > same parent. Previously it was assumed that a single variable-fields > > element was contained within the parent, which was the case for tags, > > but is not the case for side-data. > > > > Previously data was rendered as: > > > > > > > > > > Now as: > > > > > > > > > > > > > > > > > > > > > > Isn't a change like that practically an ABI break, and thus would need to > happen on a major bump? Yes, but in practice we are not tracking changes in the XML format, and major bumps are more related to ABI changes rather than to application level functionality, and probably there are not so many users using the XML format anyway. > Alternatively, just leave the old fields as they were, they looks like they > can coexist with the new ones. At least XML wise. Yes, but note that compliancy with the XSD is broken since side data printing addition, so I should fix at least that one, or revert the change/fix on the compact output (and keep strict XSD schema broken) which I'd rather not do. In my view fixing the side data output can be seen as a fix, so it should not entail a major bump. OTOH I could keep the old layout for the tags, but that would imply adding a special rule which I would like to avoid, and having all the tags grouped together has its own merits (simplifies some queries). So at the end I think that breaking the format backward-compatibility is the least evil, and we should be fine with a minor bump. Alternatively we might even consider to do a major bump, which seems a bit overkill and might suggest the idea that we are breaking ABI compatibility, which is not the case here. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".