Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Dominik 'Rathann' Mierzejewski <dominik@greysector.net>
To: ffmpeg-devel@ffmpeg.org
Subject: [FFmpeg-devel] [6.0] Segmentation fault in graph_parse() (was: [PATCH 2/2] fftools/ffmpeg_filter: initialize the) 'o' to silence the warning
Date: Mon, 9 Oct 2023 23:01:50 +0200
Message-ID: <ZSRqPv0cQ8nn7rUC@wswcmencrrcs93.greysector.net> (raw)
In-Reply-To: <77af5b6c-95d7-5ed7-6bdc-dfba720d1de6@mail.de>

On Saturday, 25 February 2023 at 18:49, Thilo Borgmann wrote:
> Am 25.02.23 um 16:26 schrieb Jun Zhao:
> > From: Jun Zhao <barryjzhao@tencent.com>
> > 
> > silence the warning: variable 'o' is used uninitialized whenever
> > '&&' condition is false
> > 
> > Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
> > ---
> >   fftools/ffmpeg_filter.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> LGTM.

Sorry to dig up an old thread, but this actually fixes a segmentation
fault when passing a non-existent filter option, so please make sure
it's back-ported to the next 6.0.x release.

To reproduce:
ffmpeg -y -f rawvideo -s 1x1 -i /dev/zero -vf palettegen=doesnt_exist=64 dummy.png

This was reported in RPM Fusion bugzilla:
https://bugzilla.rpmfusion.org/show_bug.cgi?id=6773

5.1.3 is not affected, only 6.0.

Regards,
Dominik
-- 
Fedora   https://fedoraproject.org
There should be a science of discontent. People need hard times and
oppression to develop psychic muscles.
        -- from "Collected Sayings of Muad'Dib" by the Princess Irulan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2023-10-09 21:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-25 15:26 [FFmpeg-devel] [PATCH 1/2] lavfi/coreimage: suppress OpenGL deprecation warning Jun Zhao
2023-02-25 15:26 ` [FFmpeg-devel] [PATCH 2/2] fftools/ffmpeg_filter: initialize the 'o' to silence the warning Jun Zhao
2023-02-25 17:49   ` Thilo Borgmann
2023-10-09 21:01     ` Dominik 'Rathann' Mierzejewski [this message]
2023-02-25 17:48 ` [FFmpeg-devel] [PATCH 1/2] lavfi/coreimage: suppress OpenGL deprecation warning Thilo Borgmann
2023-02-26  1:42   ` mypopy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZSRqPv0cQ8nn7rUC@wswcmencrrcs93.greysector.net \
    --to=dominik@greysector.net \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git