[FFmpeg-devel] [PATCH] enable 'dvh1' FourCC in MP4

[FFmpeg-devel] [PATCH] enable 'dvh1' FourCC in MP4

[Dominik 'Rathann' Mierzejewski]

Hi!
I'm forwarding this patch from HandBrake. Original author is
Damiano Galassi (galad87@github).

Apparently, this is required to pass through Dolby Vision metadata
to x265. Author's comment says: 'Profile 5 seems to require the "dvh1"
fourcc.' See https://github.com/HandBrake/HandBrake/pull/4838 for more
details.

diff --git a/libavformat/movenc.c b/libavformat/movenc.c
index 5608afd..f46df18 100644
--- a/libavformat/movenc.c
+++ b/libavformat/movenc.c
@@ -7689,6 +7689,7 @@ static const AVCodecTag codec_mp4_tags[] = {
     { AV_CODEC_ID_H264,            MKTAG('a', 'v', 'c', '3') },
     { AV_CODEC_ID_HEVC,            MKTAG('h', 'e', 'v', '1') },
     { AV_CODEC_ID_HEVC,            MKTAG('h', 'v', 'c', '1') },
+    { AV_CODEC_ID_HEVC,            MKTAG('d', 'v', 'h', '1') },
     { AV_CODEC_ID_MPEG2VIDEO,      MKTAG('m', 'p', '4', 'v') },
     { AV_CODEC_ID_MPEG1VIDEO,      MKTAG('m', 'p', '4', 'v') },
     { AV_CODEC_ID_MJPEG,           MKTAG('m', 'p', '4', 'v') },

Regards,
Dominik
-- 
Fedora   https://fedoraproject.org
There should be a science of discontent. People need hard times and
oppression to develop psychic muscles.
        -- from "Collected Sayings of Muad'Dib" by the Princess Irulan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] enable 'dvh1' FourCC in MP4

[Dominik 'Rathann' Mierzejewski]

On Tuesday, 27 June 2023 at 19:23, Dominik 'Rathann' Mierzejewski wrote:
> Hi!
> I'm forwarding this patch from HandBrake. Original author is
> Damiano Galassi (galad87@github).
> 
> Apparently, this is required to pass through Dolby Vision metadata
> to x265. Author's comment says: 'Profile 5 seems to require the "dvh1"
> fourcc.' See https://github.com/HandBrake/HandBrake/pull/4838 for more
> details.

It looks like this might fix https://trac.ffmpeg.org/ticket/10257 .

Regards,
Dominik
-- 
Fedora   https://fedoraproject.org
There should be a science of discontent. People need hard times and
oppression to develop psychic muscles.
        -- from "Collected Sayings of Muad'Dib" by the Princess Irulan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] enable 'dvh1' FourCC in MP4

[Dominik 'Rathann' Mierzejewski]

[-- Attachment #1: Type: text/plain, Size: 854 bytes --]

On Tuesday, 27 June 2023 at 19:37, Dominik 'Rathann' Mierzejewski wrote:
> On Tuesday, 27 June 2023 at 19:23, Dominik 'Rathann' Mierzejewski wrote:
> > Hi!
> > I'm forwarding this patch from HandBrake. Original author is
> > Damiano Galassi (galad87@github).
> > 
> > Apparently, this is required to pass through Dolby Vision metadata
> > to x265. Author's comment says: 'Profile 5 seems to require the "dvh1"
> > fourcc.' See https://github.com/HandBrake/HandBrake/pull/4838 for more
> > details.
> 
> It looks like this might fix https://trac.ffmpeg.org/ticket/10257 .

Rebased on top of current master and attached.

Regards,
Dominik
-- 
Fedora   https://fedoraproject.org
There should be a science of discontent. People need hard times and
oppression to develop psychic muscles.
        -- from "Collected Sayings of Muad'Dib" by the Princess Irulan

[-- Attachment #2: 0001-lavf-movenc-enable-dvh1-FourCC.patch --]
[-- Type: text/plain, Size: 1695 bytes --]

From 01d4ccaf32530a8f7b0a9f7d6a05ad87d560bf5a Mon Sep 17 00:00:00 2001
From: Damiano Galassi <galad87@icloud.com>
Date: Sun, 5 Feb 2023 09:24:00 +0100
Subject: [PATCH] lavf/movenc: enable dvh1 FourCC

This is required to pass through Dolby Vision metadata to x265.
Profiles 5 and 8 require the "dvh1" fourCC:
https://professional.dolby.com/siteassets/content-creation/dolby-vision-for-content-creators/dolby-vision-streams-within-the-http-live-streaming-format-v2.0-13-november-2018.pdf#unique_10
https://professional.dolby.com/siteassets/content-creation/dolby-vision-for-content-creators/dolbyvisioninmpegdashspecification_v2_0_public_20190107.pdf#unique_13
https://professional.dolby.com/siteassets/content-creation/dolby-vision-for-content-creators/dolby_vision_bitstreams_within_the_iso_base_media_file_format_dec2017.pdf

See also https://github.com/HandBrake/HandBrake/pull/4838 for more
details.

Fixes: https://trac.ffmpeg.org/ticket/10257
---
 libavformat/movenc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/libavformat/movenc.c b/libavformat/movenc.c
index 696ae5a6c9..111c68db62 100644
--- a/libavformat/movenc.c
+++ b/libavformat/movenc.c
@@ -7819,6 +7819,7 @@ static const AVCodecTag codec_mp4_tags[] = {
     { AV_CODEC_ID_H264,            MKTAG('a', 'v', 'c', '3') },
     { AV_CODEC_ID_HEVC,            MKTAG('h', 'e', 'v', '1') },
     { AV_CODEC_ID_HEVC,            MKTAG('h', 'v', 'c', '1') },
+    { AV_CODEC_ID_HEVC,            MKTAG('d', 'v', 'h', '1') },
     { AV_CODEC_ID_EVC,             MKTAG('e', 'v', 'c', '1') },
     { AV_CODEC_ID_MPEG2VIDEO,      MKTAG('m', 'p', '4', 'v') },
     { AV_CODEC_ID_MPEG1VIDEO,      MKTAG('m', 'p', '4', 'v') },
-- 
2.41.0


[-- Attachment #3: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".