From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2712D47366 for ; Tue, 5 Sep 2023 22:59:58 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 776D068C7D9; Wed, 6 Sep 2023 01:59:55 +0300 (EEST) Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B4D3F68BE9D for ; Wed, 6 Sep 2023 01:59:48 +0300 (EEST) Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-3fbd33a57b6so28472725e9.2 for ; Tue, 05 Sep 2023 15:59:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693954787; x=1694559587; darn=ffmpeg.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=JCLQKo0GWOrppjf2MTAvEzOXBdjBNtH5Zl+Bq+HdNCo=; b=Zi6EJI8GU+GF0E4z9gA7Uv4iCUdh5B01rZX2SSox1sp/mdzntQhxIcm17+E3jmo7LL kpDcQpGSALcAke4C7dGKBwXvwFBKMLaHjCju/hmdTm7IAPr/eV0l3tGODraW3u3yp2dD H7J8SNM5a+zTz8gl1q7+17YZ+N4AaQ0T8Q5qWA4syChQNGXof4/VcbLE9VOV421sL7Nv cJMYc3dMYi0l4Qmm/YeOANuaavmr9bxdfZTeV4/r4wnTBW/6I3wxSjlv8TR7zwpiIP2d 0DiEWD2vuMbNQNEzfz7BbIXPxpeZ+oE1ijSDLa95y8gS7nXiz26ekIdMW6Gm+OQCVGj0 PnrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693954787; x=1694559587; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=JCLQKo0GWOrppjf2MTAvEzOXBdjBNtH5Zl+Bq+HdNCo=; b=WnM7aDNYAFo009kWtRp0UzrnM2oyUQ/FKle5iS9prShQkhU6ATt1aTAGSdvTUo14r3 bGmfahG5VCx+3Pi2K+5GokTIvCwpj7J/RXmpI5KD4j5ruUc4lCex98MOu6rIU1VTaKeu Wl8zvXU+WUXChbgSD7vJLy7fpAMiewWI4JmLwUdgeWMGcPxLtJzEQv/QWECfhqVxXK4p fWSZ/ii06FLKnJIdJnN9jd5/jl3pf1/erddgdU7HZNAYhzyyX7HXIB1k0Dw/Niu5DG++ RDbMIjUZyE1S6SV3oxbETJYFPQNzuW7kqjzct5oHwo47xEgIp/eLS/Imdm5Po9XCCf9Z EHVQ== X-Gm-Message-State: AOJu0YzKTGpxOxBMCyhqhPmPKnX+ZbYwM95YXSNp/L42wlxOIWD0MR3b nxLR0Ym6u7jS4QPAY1nfZpuUOcKLrDcubNVA X-Google-Smtp-Source: AGHT+IFWPaKlUqbKHFXX2hZraQ5ko/BORauHS61fFtTGlSMDldkLiHmgYzYisrKq6OpIviFcY3Fblw== X-Received: by 2002:a7b:cd97:0:b0:401:c944:a4d6 with SMTP id y23-20020a7bcd97000000b00401c944a4d6mr802024wmj.28.1693954787130; Tue, 05 Sep 2023 15:59:47 -0700 (PDT) Received: from mariano ([82.84.194.139]) by smtp.gmail.com with ESMTPSA id p4-20020a7bcc84000000b003fee9cdf55esm18035087wma.14.2023.09.05.15.59.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Sep 2023 15:59:46 -0700 (PDT) Received: by mariano (Postfix, from userid 1000) id BBF74BFCDA; Wed, 6 Sep 2023 00:59:44 +0200 (CEST) Date: Wed, 6 Sep 2023 00:59:44 +0200 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches References: <20230826122328.95416-1-stefasab@gmail.com> <169306293626.20400.4712343328864304301@lain.khirnov.net> <169358345620.20400.6777068619760269139@lain.khirnov.net> <169391274067.20400.12945788077351942626@lain.khirnov.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <169391274067.20400.12945788077351942626@lain.khirnov.net> User-Agent: Mutt/2.1.4 (2021-12-11) Subject: Re: [FFmpeg-devel] [PATCH] lsws/swscale.h: introduce sws_get_gaussian_vec X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Tuesday 2023-09-05 13:19:00 +0200, Anton Khirnov wrote: > Quoting Stefano Sabatini (2023-09-01 20:28:33) > > On date Friday 2023-09-01 17:50:56 +0200, Anton Khirnov wrote: > > > Quoting Stefano Sabatini (2023-08-31 17:06:06) > > > > On date Saturday 2023-08-26 17:15:36 +0200, Anton Khirnov wrote: > > > > > Quoting Stefano Sabatini (2023-08-26 14:23:28) > > > > > > Use in place of sws_getGaussianVec. > > > > > > > > > > > > The new function enable better log handling, and provide better naming > > > > > > for the variance variable, now named standard_deviation to reflect the > > > > > > meaning of the parameter. > > > > > > > > > > > > > > Logging to NULL does not seem like an improvement to me. > > > > > > > > Adding the log_ctx. > > > > > > > > > Renaming a function parameter does not require an API break. > > > > > > > > The main point was improving the naming of the variable, but while at > > > > it I'm also adding the logging context and providing a return code to > > > > specify an error failure, and moving to snake_case convention which is > > > > the one used by the new API additions. > > > > > > As I already said above - function parameter names in a prototype are > > > purely cosmetic and have no effect on anything besides doxygen. You can > > > change them at will and even remove them entirely without breaking API > > > or ABI. > > > > > > > > The other reasons do not strike me as strong enough to warrant an API > > > break. > > > > I disagree on this: the function is probably only used internally and > > by libavfilter, and the migration is trivial enough so should cause no > > disruption anyway. > > The migration is not trivial for someone who is not familiar with the > code (such as a distro package maintainer), since the new function has a > different signature. I really do not think we should break APIs for > frivolous reasons, which includes cosmetic ones. Following this logic every API change should be considered not trivial for someone not familiar with the code, and therefore should not be committed. Also there is no evidence that external components are using this function. Besides the naming change, there are ergonomic and functional changes making the behavior of the code more correct. (Also probably it would be worth moving the naming of all the remaining functions to snake_case to provide a consistent API - and reduce the cognitive overload on the API user). _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".