From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 221FE47369 for ; Tue, 5 Sep 2023 23:08:00 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 808CB68C7B8; Wed, 6 Sep 2023 02:07:58 +0300 (EEST) Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 02C0068C318 for ; Wed, 6 Sep 2023 02:07:51 +0300 (EEST) Received: by mail-lj1-f172.google.com with SMTP id 38308e7fff4ca-2bd0a5a5abbso47323661fa.0 for ; Tue, 05 Sep 2023 16:07:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693955271; x=1694560071; darn=ffmpeg.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=h5DWMDm8hikObUllifvdXN8naGmxwJJy3Kozh2wY9b8=; b=BrIy2QbZFanqdIQhUCRUYuHCa8g36beczsf/rnSa+QZvb6qOnhy9kjYGDHpaQS7IzE w4ja2ioENvYtSiRE16FU0XXYYUypkjP4Kt4h7iQoVTaVhTP/yb5GhqasM5kEO4gEDMOX jShDpT/rUnbVtRZUeDGcS5ZZAF3WpVDq2XL5gQ7QKsWTh/tBl5LMfd7wDsHP7vRWW3T9 YbWkkZigYwFGrcZ1aKnYzHDD0rs8+vWqSOE/JLyuFWYKWwFB5GWu44oo8ZX369zQEwMj lJt+6eVRNTv6AJAwDVbRP1UxoNelb444/rChtRFp3XTMmfbXcDNFVsqu0rN+r9XS1uBp V2SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693955271; x=1694560071; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=h5DWMDm8hikObUllifvdXN8naGmxwJJy3Kozh2wY9b8=; b=HIABEx4/3NgDLDahY72VActEKesBismfHQeX0FB48tPzuOX/QZLGci996QyzO1KMPB cBQNmmJCvmSkOWRX9HEvqTaE+Y8rDljA13cla8z6V8r4nXDeiRjtujIdUGE2TZLTxUW7 YPhI3EQt4UG1K8NFjJWWRG5hBZ2uY+DgQzh0YBYMPCv0ymOtlOhiBxfuV/CAir6n8NvF 2Y4MRhJTNYfdYjLmJ7n3H+d4U9HXmbza7Aqb2+Lh9qBRCY6ekI1WypM3f14eQQHdjIf1 vJ+wKas/yPEpjG7mnECFyzgJHZTS5HOJO1kwdiOQX2LpKQHyjnQyk819gvlHFlGft3I9 9O8Q== X-Gm-Message-State: AOJu0Yz9xvJnl1ogaqotsXax/gJb1F5bmfUn3UmlKiVjEq8I5fwahvPf 3gh7qEd89OmHBD9Oh9YZz7KsQv41qrsDiE+B X-Google-Smtp-Source: AGHT+IF0ju8+LeqN9dIN/5uyG3uhBjJFlyvkDG7gdqPrAnWHTT+4gV5sTBRhAjXGKlGnmkOp1MpIeg== X-Received: by 2002:a19:4f10:0:b0:501:c49b:7673 with SMTP id d16-20020a194f10000000b00501c49b7673mr713162lfb.28.1693955270956; Tue, 05 Sep 2023 16:07:50 -0700 (PDT) Received: from mariano ([82.84.194.139]) by smtp.gmail.com with ESMTPSA id u7-20020a05600c210700b003fe4ca8decdsm21299017wml.31.2023.09.05.16.07.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Sep 2023 16:07:50 -0700 (PDT) Received: by mariano (Postfix, from userid 1000) id 11EF4BFCDA; Wed, 6 Sep 2023 01:07:49 +0200 (CEST) Date: Wed, 6 Sep 2023 01:07:48 +0200 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches , "Carotti, Elias" References: <20230825100115.393960-1-stefasab@gmail.com> <05e6607364bd43c2a1c2480d216443bc@amazon.it> <1875a1e78c2a49618256568ca30e2ac1@amazon.it> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1875a1e78c2a49618256568ca30e2ac1@amazon.it> User-Agent: Mutt/2.1.4 (2021-12-11) Subject: Re: [FFmpeg-devel] [PATCH] lavc/libx264: enable x4->params.analyse.b_fast_pskip if mb_info is set X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: "Carotti, Elias" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Tuesday 2023-09-05 12:43:35 +0000, ffmpeg-devel Mailing List wrote: [...] > On date Saturday 2023-09-02 09:20:08 +0000, Carotti, Elias wrote: > > On Thu, 2023-08-31 at 19:09 +0200, Stefano Sabatini wrote: > > > > > > > > > > > > In particular why are you turning on fast_pskip silently based on > > > > a completely different setting? > > > > > > The patch is fixing the regression introduced by the unconditional > > > setting of b_fast_pskip. > > > > > > Now the question is if it makes sense to set mb_info without > > > b_fast_pskip (in both case this should be probably documented). > > > > > > @Elias can you comment about the mb_info/b_fast_pskip use case? > > > > Sorry again for the delay in responding. > > We can safely remove it altogether. It's true we don't need to set it > > along with mb_info. > > However, it doesn't do any harm, since fast_pskip is by default set to > > true by libx264 and only turned off either explicitly by the user, or > > when using the placebo preset, or when doing lossless encoding > > (constant QP == 0.) So, I agree, let's remove these three lines. > > > > Thanks, updated. > > Ok for me Applied, thanks. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".