From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 267E347254 for ; Sat, 2 Sep 2023 15:45:14 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BDDE068C79E; Sat, 2 Sep 2023 18:45:11 +0300 (EEST) Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8447F68C225 for ; Sat, 2 Sep 2023 18:45:05 +0300 (EEST) Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-40037db2fe7so707415e9.0 for ; Sat, 02 Sep 2023 08:45:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693669505; x=1694274305; darn=ffmpeg.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=p9ge9k/Ocmm1/YxHb3mb71RfsRGXftnbAaOBwr1KPyA=; b=OyFkuynhmM1WUCqp0eABv/ndX7e0Vg7ZHA2Q1VA8H4udZ/G2TmzOo5zTNmXUMNx1Bh Rb7djFd+AmqHTz/SYIVQH229fRPOIpap/gxEHUUHFyzd8i713tTgr41wrDyx4f0fJtL6 yRiZSID8OXva/0Q+4Re12PHugDTZex6c7PlWgqe0cUM4/CmdFJhju2m4IxKGXvRcaT6o lDg31uuSTiVilDfOkL/7C+xuZEQGkVmEKB4v7GBBrSytZOlIjqei/C4NElFtjT10w1Mu tnxJBxyT/RqnzUC7DdjWX2jUK+0q10L28XQTFE3OplPyKFB1hyr4U5lrikP8Z/m9yRtg mMzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693669505; x=1694274305; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=p9ge9k/Ocmm1/YxHb3mb71RfsRGXftnbAaOBwr1KPyA=; b=D/NWrQLyaX+QPVZyF0V366RevEO1eF64ZqFZ8UL/oaWqrnWKn2d+EygMmMd2nwPhVZ xt2Z00a/MQ0es2pjzzLgaAx3foOzQhErKGhGuj8MTFgGNJgM4QeD8l2oJc9kxGVTaSTO PA0F/yZ1DQIb1gMLjTl92ekMdLtac8sEg0f9ynIO8A7f75KE+4mSmQR+WbCggNVMyrCF p/+OZRKEepQmS3Ga+dT5gyhOhNBHZlZr6CHZlxxpWcBslFHmM0iHJX68hp1XuZXEyeAD oYOYxFsyisj7CnWQ8l5cArMwKjUNqF9snU0WHlKR/MuIJOsMX6+3YE9DTabSE+CU5aAx 1Caw== X-Gm-Message-State: AOJu0YyittSZch1m2xo9oLxsoIPAMIyf9Pf+dkpEJZdxR2FlqLhL6/fy Low1WQSMKcZ7uLUpwr4TKRc= X-Google-Smtp-Source: AGHT+IEmhwrwxDdmDagD1J51caSOtBB9J75OWwoh32bxctshOx37DUiFRjm72HtyI7M28G7O4Kf0jA== X-Received: by 2002:a7b:ce16:0:b0:3fa:71db:56ff with SMTP id m22-20020a7bce16000000b003fa71db56ffmr3728164wmc.40.1693669504670; Sat, 02 Sep 2023 08:45:04 -0700 (PDT) Received: from mariano ([82.84.194.139]) by smtp.gmail.com with ESMTPSA id p5-20020a7bcc85000000b003fe1a96845bsm11493856wma.2.2023.09.02.08.45.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Sep 2023 08:45:03 -0700 (PDT) Received: by mariano (Postfix, from userid 1000) id 8AE33BFCDA; Sat, 2 Sep 2023 17:45:02 +0200 (CEST) Date: Sat, 2 Sep 2023 17:45:02 +0200 From: Stefano Sabatini To: "ffmpeg-devel@ffmpeg.org" Message-ID: Mail-Followup-To: "ffmpeg-devel@ffmpeg.org" , "Carotti, Elias" , "kierank@obe.tv" References: <20230825100115.393960-1-stefasab@gmail.com> <05e6607364bd43c2a1c2480d216443bc@amazon.it> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="KUrC0Ga6olS+Qi9O" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.1.4 (2021-12-11) Subject: Re: [FFmpeg-devel] [PATCH] lavc/libx264: enable x4->params.analyse.b_fast_pskip if mb_info is set X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: "kierank@obe.tv" , "Carotti, Elias" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --KUrC0Ga6olS+Qi9O Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On date Saturday 2023-09-02 09:20:08 +0000, Carotti, Elias wrote: > On Thu, 2023-08-31 at 19:09 +0200, Stefano Sabatini wrote: > > > > > > > > In particular why are you turning on fast_pskip silently based on a > > > completely different setting? > > > > The patch is fixing the regression introduced by the unconditional > > setting of b_fast_pskip. > > > > Now the question is if it makes sense to set mb_info without > > b_fast_pskip (in both case this should be probably documented). > > > > @Elias can you comment about the mb_info/b_fast_pskip use case? > > Sorry again for the delay in responding. > We can safely remove it altogether. It's true we don't need to set it > along with mb_info. > However, it doesn't do any harm, since fast_pskip is by default set to > true by libx264 and only turned off either explicitly by the user, or > when using the placebo preset, or when doing lossless encoding > (constant QP == 0.) > So, I agree, let's remove these three lines. Thanks, updated. --KUrC0Ga6olS+Qi9O Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-lavc-libx264-do-not-unconditionally-set-x4-params.an.patch" >From ceb00a939ab2cd0fe146020b0e4e0d80b5d16a5d Mon Sep 17 00:00:00 2001 From: Stefano Sabatini Date: Fri, 25 Aug 2023 11:35:01 +0200 Subject: [PATCH] lavc/libx264: do not unconditionally set x4->params.analyse.b_fast_pskip Fix output change regression introduced in 418c954e318. --- libavcodec/libx264.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index ce849d6c9a..cc5e1ba5b1 100644 --- a/libavcodec/libx264.c +++ b/libavcodec/libx264.c @@ -1190,7 +1190,6 @@ FF_ENABLE_DEPRECATION_WARNINGS } x4->params.analyse.b_mb_info = x4->mb_info; - x4->params.analyse.b_fast_pskip = 1; // update AVCodecContext with x264 parameters avctx->has_b_frames = x4->params.i_bframe ? -- 2.34.1 --KUrC0Ga6olS+Qi9O Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --KUrC0Ga6olS+Qi9O--