From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C4F1846A41 for ; Fri, 1 Sep 2023 18:28:47 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E4C6568C71F; Fri, 1 Sep 2023 21:28:44 +0300 (EEST) Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D733C68C705 for ; Fri, 1 Sep 2023 21:28:38 +0300 (EEST) Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-401c90ed2ecso23702205e9.0 for ; Fri, 01 Sep 2023 11:28:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693592917; x=1694197717; darn=ffmpeg.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=cpMQNBRhv9R0AJKiN4vSM2eQ2vtx2apfCGZ23oCf4+o=; b=rH7Q0I6CoaNSY6wxft2W79blwl1VPVNyqsQGJNjhI+W8WLYlr7KLLwQ2gXsDlceyUE 4mvuS2hpYQFbNxQCGjq4pdIxv4tr1Ji446FOk+KsbTMD8DTGm/IitdHnDfD9RbbnxCbG XMPIjSTE9ZVoXOmp7cjgUIsvuTBShJP1qiJwByTP9lgWT75t7/dUzmW3M0iqRxRP/KnN kPE1IxsDj1W/SJYdR0c90EAcgKk0388E6unXEptWuZdgzti0Zi3ZPoWE2Fv7zcpYEXve PL7yjHSfM06mgT/6ar5V4iM31N3UeqjqlJxtqYFi2X7xi9SQGylYCrMG8odo+6NZ5my6 3M4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693592917; x=1694197717; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=cpMQNBRhv9R0AJKiN4vSM2eQ2vtx2apfCGZ23oCf4+o=; b=Sb/l0UhxwxAR92i7vfLqtl/SLVJRhVRD95ivYpTOcCJ+dEmrPmfP9xd3oNAkKevr5b 6UuHTZI4KhQX+teHdYOXL70B5zmR4uHqhR5K7/EjAMWrGvDXuR6pOXcbsvUIjdHHNX76 TbuZmtSDFV93t7SL4QvWevcNJsKtmSnEfJAGa+OjM2UQOJnoUnvz5Tu4vN6bfS55HyeE nKirjdCbWyYePY9hWyqTTnrJsUO93lcmZfSjjxMX2zwzmBiSVtTbhZUfsZeK6EFmBs/H TY0/X5lbBEXBHOmlLvio4dTyl3DRiGfctMSZ7FhUtoQQvPkwkpdX12RFMwOxZDP+6c+6 +Fhw== X-Gm-Message-State: AOJu0YxixErS9c3yZJzKaapPNrwGp3WUhx2PndNUKkkN266pJjBftkVg P2X1iJI4PFO0OCUI+AKH9Kc/NgwPQy8= X-Google-Smtp-Source: AGHT+IFLNlW82YGJOz+Se05EkXf/+gGYECrg2n2p1BkNgoJTs+MeKPb4J8vPvZUOiwUsNjyjBqt26Q== X-Received: by 2002:a5d:6183:0:b0:317:690e:7b39 with SMTP id j3-20020a5d6183000000b00317690e7b39mr2431263wru.12.1693592917147; Fri, 01 Sep 2023 11:28:37 -0700 (PDT) Received: from mariano ([82.84.194.139]) by smtp.gmail.com with ESMTPSA id m9-20020a7bca49000000b003fed1ba0b8esm5632880wml.8.2023.09.01.11.28.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Sep 2023 11:28:36 -0700 (PDT) Received: by mariano (Postfix, from userid 1000) id E6C14BFCDA; Fri, 1 Sep 2023 20:28:33 +0200 (CEST) Date: Fri, 1 Sep 2023 20:28:33 +0200 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches References: <20230826122328.95416-1-stefasab@gmail.com> <169306293626.20400.4712343328864304301@lain.khirnov.net> <169358345620.20400.6777068619760269139@lain.khirnov.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <169358345620.20400.6777068619760269139@lain.khirnov.net> User-Agent: Mutt/2.1.4 (2021-12-11) Subject: Re: [FFmpeg-devel] [PATCH] lsws/swscale.h: introduce sws_get_gaussian_vec X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Friday 2023-09-01 17:50:56 +0200, Anton Khirnov wrote: > Quoting Stefano Sabatini (2023-08-31 17:06:06) > > On date Saturday 2023-08-26 17:15:36 +0200, Anton Khirnov wrote: > > > Quoting Stefano Sabatini (2023-08-26 14:23:28) > > > > Use in place of sws_getGaussianVec. > > > > > > > > The new function enable better log handling, and provide better naming > > > > for the variance variable, now named standard_deviation to reflect the > > > > meaning of the parameter. > > > > > > > > Logging to NULL does not seem like an improvement to me. > > > > Adding the log_ctx. > > > > > Renaming a function parameter does not require an API break. > > > > The main point was improving the naming of the variable, but while at > > it I'm also adding the logging context and providing a return code to > > specify an error failure, and moving to snake_case convention which is > > the one used by the new API additions. > > As I already said above - function parameter names in a prototype are > purely cosmetic and have no effect on anything besides doxygen. You can > change them at will and even remove them entirely without breaking API > or ABI. > > The other reasons do not strike me as strong enough to warrant an API > break. I disagree on this: the function is probably only used internally and by libavfilter, and the migration is trivial enough so should cause no disruption anyway. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".