From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7F0FD45547 for ; Thu, 31 Aug 2023 17:09:27 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CEC5068C7CA; Thu, 31 Aug 2023 20:09:24 +0300 (EEST) Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 81A4B68C6D8 for ; Thu, 31 Aug 2023 20:09:18 +0300 (EEST) Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-31c7912416bso922190f8f.1 for ; Thu, 31 Aug 2023 10:09:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693501758; x=1694106558; darn=ffmpeg.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=RuOKJZ9Cqyna7YkUKHO69kBCQXbCUQYQ8WHDJ7Mi7Uk=; b=ew5qBMFVPikzgvPESFBtohQ+Rg7uXiDW186NpLtUyfQEr3qj+tAnImZIdshVcUEqpj /TMW/27q0PyMUH3+biDGQM65HR/+rbntJfx2WAmFuHnm8OPduwtw9fWQFWv41NUbL08n sQAtl0s1NoW88+gnmcISRFj0I83pV8Rn4nONUbjyAoDBJcxrkSzHAn5tB0dPhGlicVWR LINuJykiYR8h6OM/H1YZkK4niFIbUKNzuJ0StK7G1Js3YUxul/5xzBBM4K3aGyrV7KLR FOvFZI3yRL3KKc8cKsTvjZ5Z8rC05ypenW6HSdfDFNx5SU+5vCsZ1uHSjU1VG6pW1YzP CH1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693501758; x=1694106558; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RuOKJZ9Cqyna7YkUKHO69kBCQXbCUQYQ8WHDJ7Mi7Uk=; b=XYMiRNIRLv9pBUBXSq/tq/EhY98iNMYi2suiHa4cW8KQ3gqsfpUgZypCUIo1TDmtuz oThTELwtNrkS6I0sdTH//IJmzZ8Y/6rhA5CE49g8idzr/zAwST8ZKOOXrd9KesBUg6sI nKoOYsVYBuRdD69OV42W9YAhCTIu6gLAcey4j71GkiuwodxUQrP7X/BYI/ittWyabDTj AlIQ70amildG7svnhwq/wmhT6BaSIjrvu1snVHJ411t15vLkdEBAu/E30zpj07Bvt12r wkvYWsMiuI3CqTagebz1uu9OONVoWDxzYJ731yBQ6FiAM/fX5g9ZZfBe2DG867pgqEIV McNw== X-Gm-Message-State: AOJu0YyYhWeo3ZdfMj8q3noixbNILBVfGF6Zm9uxP/sUmmUZz3o4ysXT RbNvdI8cEVIW7AuB+gv+upY= X-Google-Smtp-Source: AGHT+IGSxyWB2lSqNMuDFNC7QqEaq7ot6bjVEzXTajdGVdz6MJRloXSOFP8uD6DVGwANbz5bVR4y2A== X-Received: by 2002:adf:f802:0:b0:31a:e972:35fa with SMTP id s2-20020adff802000000b0031ae97235famr78892wrp.61.1693501757501; Thu, 31 Aug 2023 10:09:17 -0700 (PDT) Received: from mariano ([82.84.194.139]) by smtp.gmail.com with ESMTPSA id i9-20020a05600011c900b0031c77c010e1sm2744356wrx.96.2023.08.31.10.09.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Aug 2023 10:09:16 -0700 (PDT) Received: by mariano (Postfix, from userid 1000) id B06DBBFCDA; Thu, 31 Aug 2023 19:09:15 +0200 (CEST) Date: Thu, 31 Aug 2023 19:09:15 +0200 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches , Kieran Kunhya , "Carotti, Elias" References: <20230825100115.393960-1-stefasab@gmail.com> <05e6607364bd43c2a1c2480d216443bc@amazon.it> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.1.4 (2021-12-11) Subject: Re: [FFmpeg-devel] [PATCH] lavc/libx264: enable x4->params.analyse.b_fast_pskip if mb_info is set X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Kieran Kunhya , "Carotti, Elias" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Thursday 2023-08-31 15:38:09 +0100, Kieran Kunhya wrote: > On Thu, 31 Aug 2023 at 15:30, Kieran Kunhya wrote: > > > > > > > On Thu, 31 Aug 2023 at 15:12, Carotti, Elias via ffmpeg-devel < > > ffmpeg-devel@ffmpeg.org> wrote: > > > >> Hi > >> > >> -----Original Message----- > >> From: ffmpeg-devel On Behalf Of > >> Stefano Sabatini > >> Sent: Friday, August 25, 2023 12:01 PM > >> To: FFmpeg development discussions and patches > >> Cc: Stefano Sabatini > >> Subject: [EXTERNAL] [FFmpeg-devel] [PATCH] lavc/libx264: enable > >> x4->params.analyse.b_fast_pskip if mb_info is set > >> > >> CAUTION: This email originated from outside of the organization. Do not > >> click links or open attachments unless you can confirm the sender and know > >> the content is safe. > >> > >> > >> > >> x4->params.analyse.b_fast_pskip should only be forced in case mb_info > >> is set. > >> > >> Fix output change introduced in 418c954e318. > >> --- > >> libavcodec/libx264.c | 4 +++- > >> 1 file changed, 3 insertions(+), 1 deletion(-) > >> > >> diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index > >> 1a7dc7bdd5..a2877d7f75 100644 > >> --- a/libavcodec/libx264.c > >> +++ b/libavcodec/libx264.c > >> @@ -1190,7 +1190,9 @@ FF_ENABLE_DEPRECATION_WARNINGS > >> } > >> > >> x4->params.analyse.b_mb_info = x4->mb_info; > >> - x4->params.analyse.b_fast_pskip = 1; > >> + if (x4->mb_info) { > >> + x4->params.analyse.b_fast_pskip = x4->mb_info; > >> + } > >> > >> // update AVCodecContext with x264 parameters > >> avctx->has_b_frames = x4->params.i_bframe ? > >> -- > >> 2.25.1 > >> > >> > >> Sorry for the delay. I agree, this was missing in the patch. > >> Best > >> Elias > >> > > > > What does this patch actually do? > > > > Kieran > > > > In particular why are you turning on fast_pskip silently based on a > completely different setting? The patch is fixing the regression introduced by the unconditional setting of b_fast_pskip. Now the question is if it makes sense to set mb_info without b_fast_pskip (in both case this should be probably documented). @Elias can you comment about the mb_info/b_fast_pskip use case? _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".