* [FFmpeg-devel] [PATCH] lsws/ppc/yuv2rgb_altivec: Fix build in non-VSX environments with Clang
@ 2023-08-18 19:32 Brad Smith
0 siblings, 0 replies; 4+ messages in thread
From: Brad Smith @ 2023-08-18 19:32 UTC (permalink / raw)
To: ffmpeg-devel
lsws/ppc/yuv2rgb_altivec: Fix build in non-VSX environments with Clang
Add a check for the existence of the vec_xl() function. Clang provides
the function even with VSX not enabled.
---
configure | 8 ++++++++
libswscale/ppc/yuv2rgb_altivec.c | 4 ++--
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/configure b/configure
index 932998b8d6..268435fbdb 100755
--- a/configure
+++ b/configure
@@ -2154,6 +2154,7 @@ ARCH_EXT_LIST_PPC="
ldbrx
power8
ppc4xx
+ vec_xl
vsx
"
@@ -2679,6 +2680,7 @@ altivec_deps="ppc"
dcbzl_deps="ppc"
ldbrx_deps="ppc"
ppc4xx_deps="ppc"
+vec_xl_deps="altivec"
vsx_deps="altivec"
power8_deps="vsx"
@@ -6218,6 +6220,11 @@ elif enabled ppc; then
check_cpp_condition power8 "altivec.h" "defined(_ARCH_PWR8)"
fi
+ if enabled altivec && disabled vsx; then
+ check_cc vec_xl altivec.h "const unsigned char *y1i = { 0 };
+ vector unsigned char y0 = vec_xl(0, y1i);"
+ fi
+
elif enabled riscv; then
enabled rvv && check_inline_asm rvv '".option arch, +v\nvsetivli zero, 0, e8, m1, ta, ma"'
@@ -7728,6 +7735,7 @@ if enabled ppc; then
echo "POWER8 enabled ${power8-no}"
echo "PPC 4xx optimizations ${ppc4xx-no}"
echo "dcbzl available ${dcbzl-no}"
+ echo "vec_xl available ${vec_xl-no}"
fi
if enabled loongarch; then
echo "LSX enabled ${lsx-no}"
diff --git a/libswscale/ppc/yuv2rgb_altivec.c b/libswscale/ppc/yuv2rgb_altivec.c
index 5e1033a973..8b0a93796f 100644
--- a/libswscale/ppc/yuv2rgb_altivec.c
+++ b/libswscale/ppc/yuv2rgb_altivec.c
@@ -284,7 +284,7 @@ static inline void cvtyuvtoRGB(SwsContext *c, vector signed short Y,
* ------------------------------------------------------------------------------
*/
-#if !HAVE_VSX
+#if !HAVE_VEC_XL
static inline vector unsigned char vec_xl(signed long long offset, const ubyte *addr)
{
const vector unsigned char *v_addr = (const vector unsigned char *) (addr + offset);
@@ -292,7 +292,7 @@ static inline vector unsigned char vec_xl(signed long long offset, const ubyte *
return (vector unsigned char) vec_perm(v_addr[0], v_addr[1], align_perm);
}
-#endif /* !HAVE_VSX */
+#endif /* !HAVE_VEC_XL */
#define DEFCSP420_CVT(name, out_pixels) \
static int altivec_ ## name(SwsContext *c, const unsigned char **in, \
--
2.41.0
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread* [FFmpeg-devel] [PATCH] lsws/ppc/yuv2rgb_altivec: Fix build in non-VSX environments with Clang
@ 2023-08-08 1:02 Brad Smith
2023-08-11 23:49 ` Brad Smith
2023-08-12 15:19 ` Michael Niedermayer
0 siblings, 2 replies; 4+ messages in thread
From: Brad Smith @ 2023-08-08 1:02 UTC (permalink / raw)
To: ffmpeg-devel
lsws/ppc/yuv2rgb_altivec: Fix build in non-VSX environments with Clang
libswscale/ppc/yuv2rgb_altivec.c:288:36: error: redeclaration of 'vec_xl' must have the 'overloadable' attribute
---
libswscale/ppc/yuv2rgb_altivec.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libswscale/ppc/yuv2rgb_altivec.c b/libswscale/ppc/yuv2rgb_altivec.c
index 5e1033a973..6ef2441d8a 100644
--- a/libswscale/ppc/yuv2rgb_altivec.c
+++ b/libswscale/ppc/yuv2rgb_altivec.c
@@ -284,7 +284,7 @@ static inline void cvtyuvtoRGB(SwsContext *c, vector signed short Y,
* ------------------------------------------------------------------------------
*/
-#if !HAVE_VSX
+#if !HAVE_VSX && !defined(__clang__)
static inline vector unsigned char vec_xl(signed long long offset, const ubyte *addr)
{
const vector unsigned char *v_addr = (const vector unsigned char *) (addr + offset);
@@ -292,7 +292,7 @@ static inline vector unsigned char vec_xl(signed long long offset, const ubyte *
return (vector unsigned char) vec_perm(v_addr[0], v_addr[1], align_perm);
}
-#endif /* !HAVE_VSX */
+#endif /* !HAVE_VSX && !__clang__ */
#define DEFCSP420_CVT(name, out_pixels) \
static int altivec_ ## name(SwsContext *c, const unsigned char **in, \
--
2.41.0
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [FFmpeg-devel] [PATCH] lsws/ppc/yuv2rgb_altivec: Fix build in non-VSX environments with Clang
2023-08-08 1:02 Brad Smith
@ 2023-08-11 23:49 ` Brad Smith
2023-08-12 15:19 ` Michael Niedermayer
1 sibling, 0 replies; 4+ messages in thread
From: Brad Smith @ 2023-08-11 23:49 UTC (permalink / raw)
To: FFmpeg development discussions and patches
Just FYI, we have had this in the OpenBSD and FreeBSD packages for quite
awhile
to be able to build on powerpc64.
On 2023-08-07 9:02 p.m., Brad Smith wrote:
> lsws/ppc/yuv2rgb_altivec: Fix build in non-VSX environments with Clang
>
> libswscale/ppc/yuv2rgb_altivec.c:288:36: error: redeclaration of 'vec_xl' must have the 'overloadable' attribute
> ---
> libswscale/ppc/yuv2rgb_altivec.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libswscale/ppc/yuv2rgb_altivec.c b/libswscale/ppc/yuv2rgb_altivec.c
> index 5e1033a973..6ef2441d8a 100644
> --- a/libswscale/ppc/yuv2rgb_altivec.c
> +++ b/libswscale/ppc/yuv2rgb_altivec.c
> @@ -284,7 +284,7 @@ static inline void cvtyuvtoRGB(SwsContext *c, vector signed short Y,
> * ------------------------------------------------------------------------------
> */
>
> -#if !HAVE_VSX
> +#if !HAVE_VSX && !defined(__clang__)
> static inline vector unsigned char vec_xl(signed long long offset, const ubyte *addr)
> {
> const vector unsigned char *v_addr = (const vector unsigned char *) (addr + offset);
> @@ -292,7 +292,7 @@ static inline vector unsigned char vec_xl(signed long long offset, const ubyte *
>
> return (vector unsigned char) vec_perm(v_addr[0], v_addr[1], align_perm);
> }
> -#endif /* !HAVE_VSX */
> +#endif /* !HAVE_VSX && !__clang__ */
>
> #define DEFCSP420_CVT(name, out_pixels) \
> static int altivec_ ## name(SwsContext *c, const unsigned char **in, \
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [FFmpeg-devel] [PATCH] lsws/ppc/yuv2rgb_altivec: Fix build in non-VSX environments with Clang
2023-08-08 1:02 Brad Smith
2023-08-11 23:49 ` Brad Smith
@ 2023-08-12 15:19 ` Michael Niedermayer
1 sibling, 0 replies; 4+ messages in thread
From: Michael Niedermayer @ 2023-08-12 15:19 UTC (permalink / raw)
To: FFmpeg development discussions and patches
[-- Attachment #1.1: Type: text/plain, Size: 1687 bytes --]
On Mon, Aug 07, 2023 at 09:02:19PM -0400, Brad Smith wrote:
> lsws/ppc/yuv2rgb_altivec: Fix build in non-VSX environments with Clang
>
> libswscale/ppc/yuv2rgb_altivec.c:288:36: error: redeclaration of 'vec_xl' must have the 'overloadable' attribute
> ---
> libswscale/ppc/yuv2rgb_altivec.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libswscale/ppc/yuv2rgb_altivec.c b/libswscale/ppc/yuv2rgb_altivec.c
> index 5e1033a973..6ef2441d8a 100644
> --- a/libswscale/ppc/yuv2rgb_altivec.c
> +++ b/libswscale/ppc/yuv2rgb_altivec.c
> @@ -284,7 +284,7 @@ static inline void cvtyuvtoRGB(SwsContext *c, vector signed short Y,
> * ------------------------------------------------------------------------------
> */
>
> -#if !HAVE_VSX
> +#if !HAVE_VSX && !defined(__clang__)
> static inline vector unsigned char vec_xl(signed long long offset, const ubyte *addr)
> {
> const vector unsigned char *v_addr = (const vector unsigned char *) (addr + offset);
> @@ -292,7 +292,7 @@ static inline vector unsigned char vec_xl(signed long long offset, const ubyte *
>
> return (vector unsigned char) vec_perm(v_addr[0], v_addr[1], align_perm);
> }
> -#endif /* !HAVE_VSX */
> +#endif /* !HAVE_VSX && !__clang__ */
Iam not altivec maintainer but i think the correct way to do this is to
test for vec_xl() in configure and have some sort of HAVE_VEC_XL
thats more robust than such chain of conditional checks
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Elect your leaders based on what they did after the last election, not
based on what they say before an election.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-18 19:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-18 19:32 [FFmpeg-devel] [PATCH] lsws/ppc/yuv2rgb_altivec: Fix build in non-VSX environments with Clang Brad Smith
-- strict thread matches above, loose matches on Subject: below --
2023-08-08 1:02 Brad Smith
2023-08-11 23:49 ` Brad Smith
2023-08-12 15:19 ` Michael Niedermayer
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git