From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 48D7D46EB8 for ; Sun, 16 Jul 2023 09:42:55 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CC2DC68C5C8; Sun, 16 Jul 2023 12:42:52 +0300 (EEST) Received: from nef.ens.fr (nef2.ens.fr [129.199.96.40]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0402C68C4BE for ; Sun, 16 Jul 2023 12:42:46 +0300 (EEST) X-ENS-nef-client: 129.199.129.80 ( name = phare.normalesup.org ) Received: from phare.normalesup.org (phare.normalesup.org [129.199.129.80]) by nef.ens.fr (8.14.4/1.01.28121999) with ESMTP id 36G9gkP9028965 for ; Sun, 16 Jul 2023 11:42:46 +0200 Received: by phare.normalesup.org (Postfix, from userid 1001) id 288B5EB5B7; Sun, 16 Jul 2023 11:42:46 +0200 (CEST) Date: Sun, 16 Jul 2023 11:42:46 +0200 From: Nicolas George To: FFmpeg development discussions and patches Message-ID: References: <20230715235832.64221-1-jamrial@gmail.com> MIME-Version: 1.0 In-Reply-To: <20230715235832.64221-1-jamrial@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (nef.ens.fr [129.199.96.32]); Sun, 16 Jul 2023 11:42:46 +0200 (CEST) Subject: Re: [FFmpeg-devel] [PATCH] avcodec/x86/mathops: use constrained immediate operands X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============1190363918352099305==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============1190363918352099305== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="eQq48JQ6LJ5xHjPo" Content-Disposition: inline --eQq48JQ6LJ5xHjPo Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable James Almer (12023-07-15): > Should fix assembling with binutil as >=3D 2.41 >=20 > Signed-off-by: James Almer > --- > This is IMO a big breakage. binutil's as has until now clipped these valu= es on > its own, and never required the compiler to do it. I confirm it fixes the build failures on up-to-date Debian testing. OTOH, I ran a benchmark (decoding some x264): 474134 mod 488751 orig 494359 mod 498554 orig 508958 orig 514246 orig 518160 mod 528427 orig 530223 mod 534762 mod 536415 orig 548434 orig 550789 orig 551716 mod 553951 orig 561754 orig 572688 mod 580254 mod 581205 orig 583856 mod 583939 orig 584748 orig 594143 orig 600681 mod 607596 mod 612757 mod 621033 orig 624567 orig 626346 mod 627309 mod 628242 mod 638344 mod The numbers are the sum of the =E2=80=9Cuser=E2=80=9D column of the -benchm= ark_all output, on an AMD Ryzen 3 3200U and Debaian stable. The mod lines are when I disabled the two faulty functions. They are all over the place, it is hard to be sure, but it seems to indicate that, as you suspected, the benefit is not that big. Regards, --=20 Nicolas George --eQq48JQ6LJ5xHjPo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE6ooRQGBoNzw0KnwPcZVLI8pNxgwFAmSzu5IACgkQcZVLI8pN xgy8bw//UkDMc36S3yxtZnsk8qVy64Jy5vdxK5F6wFz34ljfoC6Vllzi/3Xt+Nr5 1ccnCR6Xr0OVxhvlar482cBgKG9mqqG0hHJGNQ88owuDVrGVpZ0YbePR+Nv0XRe7 sdy19lI8FQsIOlbIbhoeExiDTdnNFpJExJ+zeg6GWK+rBZJ+IeBsG9ENqXxJ8ZQB gDAxoO5wHHkKugOhYjWzLUQjRL3rAF/RDJ0xJtM2cygmCkc5x4M5tQm2RYySJsc6 lK1ZVK1iN4vjhL3O4XayH+Ejex8o0CpUWjMmMUU+3wtSPgoWeCUCidPoJbQqXXAs 5pVJZPBsFzL8ritMw30wQqQ8ZXRkSI45imxLfIX5oHUw73u6TjMiyl+nuSCToLLm gE30ACM+AsxmVe2yFpTWyXZmCu4aBgNqntIcjPflppjWEUx1X4SMKImMOu7s1kLd jlYl6KUbkDnh9daPRhYr+KdqaHLvwmJEo/jXr9wBQ904HSKaK0wmveo3q2ZqKJBz V4GBcUYkKwFOj9gNA4pzmNqVqUDeaW/ERNxQNqWhzyRyFyRgAUSLNf5dEj4PKlb6 35a092SEBu/a9Z0YYAVkX3uro4oQKFZbuCLGBaIUV+jN8LJfWfL+noJZjHUXz/z1 E/9YrHjsncN4UZ1yowrFT0L2MyXNv5o3OExsBYnZL0fB6LdW9D8= =qR05 -----END PGP SIGNATURE----- --eQq48JQ6LJ5xHjPo-- --===============1190363918352099305== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============1190363918352099305==--