Re: [FFmpeg-devel] [PATCH] avcodec/x86/mathops: use constrained immediate operands

[Nicolas George <george@nsup.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1219 bytes --]

James Almer (12023-07-15):
> Should fix assembling with binutil as >= 2.41
> 
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
> This is IMO a big breakage. binutil's as has until now clipped these values on
> its own, and never required the compiler to do it.

I confirm it fixes the build failures on up-to-date Debian testing.

OTOH, I ran a benchmark (decoding some x264):

474134     mod
488751 orig
494359     mod
498554 orig
508958 orig
514246 orig
518160     mod
528427 orig
530223     mod
534762     mod
536415 orig
548434 orig
550789 orig
551716     mod
553951 orig
561754 orig
572688     mod
580254     mod
581205 orig
583856     mod
583939 orig
584748 orig
594143 orig
600681     mod
607596     mod
612757     mod
621033 orig
624567 orig
626346     mod
627309     mod
628242     mod
638344     mod

The numbers are the sum of the “user” column of the -benchmark_all
output, on an AMD Ryzen 3 3200U and Debaian stable. The mod lines are
when I disabled the two faulty functions.

They are all over the place, it is hard to be sure, but it seems to
indicate that, as you suspected, the benefit is not that big.

Regards,

-- 
  Nicolas George

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".