[FFmpeg-devel] [PATCH] libavcodec/ansi: fix ECMA-48 SGR parameter 49

[FFmpeg-devel] [PATCH] libavcodec/ansi: fix ECMA-48 SGR parameter 49

[Jonas Lindner]

As can be seen in man console_codes this parameter sets the default
background color

Signed-off-by: Jonas Lindner <jolindner@gmx.de>
---
  libavcodec/ansi.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/ansi.c b/libavcodec/ansi.c
index 49c3770c4c..d8d32bafbd 100644
--- a/libavcodec/ansi.c
+++ b/libavcodec/ansi.c
@@ -330,7 +330,7 @@ FF_ENABLE_DEPRECATION_WARNINGS
                  s->bg = index < 16 ? ansi_to_cga[index] : index;
                  i += 2;
              } else if (m == 49) {
-                s->fg = ansi_to_cga[DEFAULT_BG_COLOR];
+                s->bg = ansi_to_cga[DEFAULT_BG_COLOR];
              } else {
                  avpriv_request_sample(avctx, "Unsupported rendition
parameter");
              }
--
2.34.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] libavcodec/ansi: fix ECMA-48 SGR parameter 49

[Peter Ross]

[-- Attachment #1.1: Type: text/plain, Size: 845 bytes --]

On Mon, Jul 10, 2023 at 12:06:33AM +0200, Jonas Lindner wrote:
> As can be seen in man console_codes this parameter sets the default
> background color
> 
> Signed-off-by: Jonas Lindner <jolindner@gmx.de>
> ---
>  libavcodec/ansi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavcodec/ansi.c b/libavcodec/ansi.c
> index 49c3770c4c..d8d32bafbd 100644
> --- a/libavcodec/ansi.c
> +++ b/libavcodec/ansi.c
> @@ -330,7 +330,7 @@ FF_ENABLE_DEPRECATION_WARNINGS
>                  s->bg = index < 16 ? ansi_to_cga[index] : index;
>                  i += 2;
>              } else if (m == 49) {
> -                s->fg = ansi_to_cga[DEFAULT_BG_COLOR];
> +                s->bg = ansi_to_cga[DEFAULT_BG_COLOR];

Well spotted. Applied.

-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".