On Tue, Jun 27, 2023 at 01:53:01AM +0200, Michael Niedermayer wrote:
> Changes since v4:
> * vissualization shows modulation and frequency
> * limit station search to AM shortwave and FM broadcast band
> * enable FM Probing with some minor adjustments, it seems good enough
> * FM Mono demodulation

fantastic work!

is the fm demodulator supposed to work automagically?
i don't seem to discover anything with this command:

    ffplay -sdr_freq 105.5M -station_freq 107.5M -f sdr foo

also tried fiddling with -rtlsdr_fixes

whereas i do get signal with:

    rtl_fm -f 107.5M -M wbfm

> * some seeking fixes 
> 
> Known issues:
> * wraparound with seeking is not behaving ideal
> * not all options are documented
> * no fate test

testing this patch against master i bump into the problem of avpriv_kbd_window_init being undefined.
also if i naively replace it with ff_kbd_window_init, observe FF_KBD_WINDOW_MAX assert in kbd_window_init.

cheers,

-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)