From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1E8AB45C68 for ; Sat, 29 Apr 2023 08:46:42 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id F15F368BFFE; Sat, 29 Apr 2023 11:46:39 +0300 (EEST) Received: from nef.ens.fr (nef2.ens.fr [129.199.96.40]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C0EED68BB83 for ; Sat, 29 Apr 2023 11:46:32 +0300 (EEST) X-ENS-nef-client: 129.199.129.80 ( name = phare.normalesup.org ) Received: from phare.normalesup.org (phare.normalesup.org [129.199.129.80]) by nef.ens.fr (8.14.4/1.01.28121999) with ESMTP id 33T8kViZ027010 for ; Sat, 29 Apr 2023 10:46:32 +0200 Received: by phare.normalesup.org (Postfix, from userid 1001) id CC3BDEB5BF; Sat, 29 Apr 2023 10:46:31 +0200 (CEST) Date: Sat, 29 Apr 2023 10:46:31 +0200 From: Nicolas George To: FFmpeg development discussions and patches Message-ID: References: <20230427142601.2613-1-anton@khirnov.net> <20230427142601.2613-8-anton@khirnov.net> <4d9e2ce9-fdfb-3fcd-bd7d-07d9bbe5860d@gmail.com> MIME-Version: 1.0 In-Reply-To: X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (nef.ens.fr [129.199.96.32]); Sat, 29 Apr 2023 10:46:32 +0200 (CEST) Subject: Re: [FFmpeg-devel] [PATCH 08/21] fftools/ffmpeg_filter: add filtergraph private data X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============4224843413774629599==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============4224843413774629599== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="r9psvD5pvCIhWvp6" Content-Disposition: inline --r9psvD5pvCIhWvp6 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Nicolas George (12023-04-28): > And during the work of turning all into threads, opportunities to split > the structure in more logical ways with less code noise will almost > certainly present themselves. I had intended to not reply further on this, but I just had a severe case of esprit de l'ecalier, so I just add this: For example, it is entirely possible that a lot of these =E2=80=9Cprivate= =E2=80=9D fields could become local variables and functions parameters in the threads. That would be elegant and efficient. But now we will never know, because they will all be stuffed in a private context, according to =E2=80=9Cgood practices=E2=80=9D, and that wi= ll spare the effort of checking what their exact scope is. Regards, --=20 Nicolas George --r9psvD5pvCIhWvp6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE6ooRQGBoNzw0KnwPcZVLI8pNxgwFAmRM2WUACgkQcZVLI8pN xgypBA/+Pw2tXcD13g2eVFtGqbWKABkBaEHnJwvF34kah/8RZ+iJFEr4uw4sTDm4 UaS3ob3ZRhz2eIuakE54zcWthdtwVPZhX6FcuRVpzM/IUGnpPoM0kP9M2tbFaiZv 0gdNYH8aej3uXiLbMgYUXfYhCYOMHHN9gYwhdyE1SIeGvjT6M96sLCT1dLpUPTXB ATJnw6UAwSY+t1fSiFeDb4posvJSp/8isWCHiffK15bAsPGsBI5l3GR9X75swZAr h0OsmiOLMRtKeD6jHwHB/gPVnKvjBxdiLNPFQbqK5Ig9qc5HaMfJZTT08Lh96Ril bRxv8RgQy+dfieDa/zJx3ZCN1S9a5Ll7WyOtOG24XXLreYzLvno/8WhqDZMe9u4x pj2HnZkeC3YgYeFXRosTKaA7D9b1jPC3MCiXlMY10gUfg3LtDSj73MMNsRZWr/yE yrbrDswQ2Hlwd3N6fi+hOOzuvOU719SrHXHD0e77qSpqvemxXrHXCNC7cRpUt3Cq XBIrl4v9AeruqpmVcLvR20GKa2hXjpN3rIgBUi0r6vHAkHKIDJK+N9iVNBQTs7Db 42P0FaZiAYHT70ZFj2OqGTfhYqrqTBVA4KSRoPYCh4mQxvtoTZfA8WQYESsjoHDP w/08VzmqxNkQEl3n1CBTepDuR1bCU3lM02hIukSoDLccWKTISdQ= =z6vD -----END PGP SIGNATURE----- --r9psvD5pvCIhWvp6-- --===============4224843413774629599== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============4224843413774629599==--