From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 845E145FD7 for ; Fri, 28 Apr 2023 11:20:57 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DCE5C68BFA0; Fri, 28 Apr 2023 14:20:54 +0300 (EEST) Received: from nef.ens.fr (nef2.ens.fr [129.199.96.40]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6D0B968BF66 for ; Fri, 28 Apr 2023 14:20:48 +0300 (EEST) X-ENS-nef-client: 129.199.129.80 ( name = phare.normalesup.org ) Received: from phare.normalesup.org (phare.normalesup.org [129.199.129.80]) by nef.ens.fr (8.14.4/1.01.28121999) with ESMTP id 33SBKluA015489 for ; Fri, 28 Apr 2023 13:20:47 +0200 Received: by phare.normalesup.org (Postfix, from userid 1001) id 9B18AEB5BF; Fri, 28 Apr 2023 13:20:47 +0200 (CEST) Date: Fri, 28 Apr 2023 13:20:47 +0200 From: Nicolas George To: FFmpeg development discussions and patches Message-ID: References: <20230428095508.221826-1-george@nsup.org> <20230428095508.221826-2-george@nsup.org> <2230476.eJ43uMOuf2@mako.vk5ztv.ampr.org> MIME-Version: 1.0 In-Reply-To: <2230476.eJ43uMOuf2@mako.vk5ztv.ampr.org> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (nef.ens.fr [129.199.96.32]); Fri, 28 Apr 2023 13:20:47 +0200 (CEST) Subject: Re: [FFmpeg-devel] [PATCH 2/8] lavu: new AVWriter API X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============1578403391089121971==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============1578403391089121971== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="DIXjK8iLhnVgld/H" Content-Disposition: inline --DIXjK8iLhnVgld/H Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Rodney Baker (12023-04-28): > I'm not normally a reviewer, but I noticed a few minor grammatical things= that=20 > stood out - hope this is OK.=20 Thanks, it is absolutely useful. > Nit - s/compating/comparing/ Fixed. > > +**Note:** AVWriter is 8-bit clean, the strings it manipulates can be > Use a hyphen or a semicolon rather than a comma after "clean".=20 After consideration, a semicolon would be too strong; a hyphen would be strange, too literary. > > +In mainstream C, a function that needs to return a string usually have= two > > +options: either they accept pointer to a buffer that they fill or they > > +allocate the buffer themselves and return it. Both these options have > > +drawbacks, which one is best depends on the circumstances of the calle= r. > Semicolon instead of comma after "drawbacks". Same here, I find a semicolon would be too strong. > Drop comma after "circumstances".=20 Done. > > +AVWriter also makes the work of the called function easier by providing > > +convenient functions to append to the string that completely wrap error > > +checks. Note that it only works for strings created as streams; functi= ons > > +that need random access to the string already built still need to mana= ge > > +their own buffers; some AVWriter implementations can still help for th= at. > Full stop after "buffers" (instead of semicolon - you've already used one= =20 > previously in the same sentence).=20 Disagree on this one: the last part should still be in the sentence that starts with =E2=80=9CNote that=E2=80=9D. There is no problem in having mult= iple semicolons to separate parts on the same level. Regards, --=20 Nicolas George --DIXjK8iLhnVgld/H Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE6ooRQGBoNzw0KnwPcZVLI8pNxgwFAmRLrA0ACgkQcZVLI8pN xgzmIw/+Mj1n+wEb5feBlAN646AjEpxJmse9y2IIHdtogaklXpuaedxt8CPEe3q9 9lANjKPUrrO2KloSR2X3otVSgM0BvdB74fArrrz9ngLBePo/lLGUhbn7s/8N8xpj k4NTuceBBTv/ukvjcl339GF2/Jjcc/Gm4eE9kH63HWrusoTxKlPN4OX93sdZeIea 24b1EtzOtQSbYnSMzmxO9ErWLkh4mt9sHNoQThs3Fl2HqcVk5O/ltqPHmevLMldr u0kVHoajVhh9Uzbdg8D953ISdqGykMWQUUqwcdMZFntnz0p6BXf7FHFyMOkkh6V8 fSE98M0Fd8/oObEYtKLJg1nZAWPHW+XqkRxNQeLgWlPZxQdw5doG8Zn2PthzTnBA umtwannd74whJX7xwvT4qqWv4xvY6SN3AD1um4olFGF31NL/1izftq3DvYknuAIi ftWnOP+mQgWmJdQrdtrYdeKTLWLoe3fFD6OFqGF/a4zgSrRBFyWqtEOAX8I87lFD kGgwpnEfSBDRU4ozInFB8bxYleS1/4ffGOCorq9ME/CRX69+voXv4ZTpFpnJ0XnL MKpyq2/3lwFvfRDvNjPYxmBKH7TvHe558fvBpNPaUTmtiokb2dk1/dy5mCIKWnIT WO+fGUX2aZbFJd5HRdJZfwYYmI7IVsQV2F10wco6tm3ClFNHf9c= =Ryc0 -----END PGP SIGNATURE----- --DIXjK8iLhnVgld/H-- --===============1578403391089121971== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============1578403391089121971==--