From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D037A4583F for ; Tue, 25 Apr 2023 14:37:36 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7207268BEE4; Tue, 25 Apr 2023 17:37:33 +0300 (EEST) Received: from nef.ens.fr (nef2.ens.fr [129.199.96.40]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 613B968B274 for ; Tue, 25 Apr 2023 17:37:27 +0300 (EEST) X-ENS-nef-client: 129.199.129.80 ( name = phare.normalesup.org ) Received: from phare.normalesup.org (phare.normalesup.org [129.199.129.80]) by nef.ens.fr (8.14.4/1.01.28121999) with ESMTP id 33PEbQcj010023 for ; Tue, 25 Apr 2023 16:37:26 +0200 Received: by phare.normalesup.org (Postfix, from userid 1001) id 6F94BEB5BF; Tue, 25 Apr 2023 16:37:26 +0200 (CEST) Date: Tue, 25 Apr 2023 16:37:26 +0200 From: Nicolas George To: FFmpeg development discussions and patches Message-ID: References: <3587873f-7b50-a98c-70ce-443aeb93b9ae@passwd.hu> <168225127500.3843.6466868436482522174@lain.khirnov.net> <5e23352c-434c-1135-827d-49438c7cf11@passwd.hu> <168228099822.3843.5128524518650472655@lain.khirnov.net> <299fbcbb-5730-f06-8532-ee0e33a1a39@passwd.hu> <168233055057.3843.7983466111074826888@lain.khirnov.net> <168236424151.3843.16530979427868744402@lain.khirnov.net> <168237052183.3843.15583837147319364672@lain.khirnov.net> MIME-Version: 1.0 In-Reply-To: <168237052183.3843.15583837147319364672@lain.khirnov.net> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (nef.ens.fr [129.199.96.32]); Tue, 25 Apr 2023 16:37:26 +0200 (CEST) Subject: Re: [FFmpeg-devel] [PATCH v2] fftools/ffmpeg_mux: fix reporting muxer EOF as error X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============5346853926971760048==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============5346853926971760048== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="CuYaR98NfPF1Vyru" Content-Disposition: inline --CuYaR98NfPF1Vyru Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Anton Khirnov (12023-04-24): > I think the point on which we disagree is your notion of "error > conditions" as being basically interchangeable. The way everything, FFmpeg and all other sane system work, is that the caller handles the very few errors it know how to handle (EAGAIN certainly, maybe a few other depending on the situation), and everything else is passed to the user in human-readable form, in the hope the user can deal with it. So in a sence, most errors are basically interchangeable for the application, and it is how it is supposed to be. For example EISDIR, ENOENT, ENOTDIR are almost always interchangeable for the application, and really mean to the user =E2=80=9Cyou mistyped the file name somehow=E2= =80=9D. > In both of these cases the CLI code as it is now is correct. Absolutely not. The documentation states that muxers return errors and nothing else, there is no special case for EOF, unlike demuxers, and therefore this patch is a waste of code. --=20 Nicolas George --CuYaR98NfPF1Vyru Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE6ooRQGBoNzw0KnwPcZVLI8pNxgwFAmRH5aQACgkQcZVLI8pN xgwxGQ/9HiDZkIDnyViP+goDh63fImmsgwqlxnZwRTspOv9qvwjiDNEkQS6Htnia h39BCjPKs4pnflmA4ODFA4QkQRheb4us+nkcoC8VHstV234LP7RoIQGepgjLUj5K PrKK6gxdbX85G1nmQeJpZ1Gl7I45dh2yOl+nMvqP7HRIL6TNRA+h6rFdc+c2vgE0 PJOHHEJgnT8TZnGQe/1gSqNw/N6w2f9siQTwdo6ab/K/pWtrp+zRuy8ipWaZqPCu 8aPWpUwcZ82Lxr5cDgl1RXzPW97r8kNBaNz6KUQ+T1ZvoF/jqwCgGgX+dUSHOcbA VAKMN/YZV4jSNxTdtwBOiAPhFAcAQTkggpxuVHmKo4hjXEVraB75yEoPsAGak59+ tl91se/CtOwxqOpfF/adrBMm3fMIq+ACvdiona8naWVztAetqCc7xaspAFtzDMNY gllNj5Wekq9MWdo9RPu9kbTsf0QrPFIjjAGeFstrA6uTMXy0oY4M7DQDw8Ce0rMJ kaKPCarqZ4+V8WrGJ8QAS6vWMe5ojUFMFpcgYO+ZLULMGgvYGrWNWJd/35MBYY60 obiMtUdQoLbpo5pJv6lV4w+m7q/IWEKC4ZGkx90QKFBw8raFDneHCztWmMN7/zm8 ryPQGr406O4ctwHtYz/3aA/wCY5n7De/F6FdCwIZE60ZPey6WYo= =+VIS -----END PGP SIGNATURE----- --CuYaR98NfPF1Vyru-- --===============5346853926971760048== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============5346853926971760048==--