From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3AD5445BFE for ; Mon, 24 Apr 2023 23:31:33 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A50C568BF86; Tue, 25 Apr 2023 02:31:30 +0300 (EEST) Received: from nef.ens.fr (nef2.ens.fr [129.199.96.40]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 24AD768BF07 for ; Tue, 25 Apr 2023 02:31:24 +0300 (EEST) X-ENS-nef-client: 129.199.129.80 ( name = phare.normalesup.org ) Received: from phare.normalesup.org (phare.normalesup.org [129.199.129.80]) by nef.ens.fr (8.14.4/1.01.28121999) with ESMTP id 33OKfrOL010197 for ; Mon, 24 Apr 2023 22:41:53 +0200 Received: by phare.normalesup.org (Postfix, from userid 1001) id A5810EB5BF; Mon, 24 Apr 2023 22:41:53 +0200 (CEST) Date: Mon, 24 Apr 2023 22:41:53 +0200 From: Nicolas George To: FFmpeg development discussions and patches Message-ID: References: <168224247972.9711.2598182970187678748@lain.khirnov.net> <168224350165.3843.7618353870792865075@lain.khirnov.net> <3587873f-7b50-a98c-70ce-443aeb93b9ae@passwd.hu> <168225127500.3843.6466868436482522174@lain.khirnov.net> <5e23352c-434c-1135-827d-49438c7cf11@passwd.hu> <168228099822.3843.5128524518650472655@lain.khirnov.net> <299fbcbb-5730-f06-8532-ee0e33a1a39@passwd.hu> <168233055057.3843.7983466111074826888@lain.khirnov.net> MIME-Version: 1.0 In-Reply-To: X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (nef.ens.fr [129.199.96.32]); Mon, 24 Apr 2023 22:41:53 +0200 (CEST) Subject: Re: [FFmpeg-devel] [PATCH v2] fftools/ffmpeg_mux: fix reporting muxer EOF as error X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============5045482701853277960==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============5045482701853277960== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="50etQCyVRUW0eDys" Content-Disposition: inline --50etQCyVRUW0eDys Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Marton Balint (12023-04-24): > The API change is that muxers are no longer allowed to return AVERROR_EOF > for an error condition. There is no API change because applications are not allowed to write muxers. At worst, it would be an internal API change. But it is not even an internal API change, because AVERROR_EOF was not allowed as a return code from a muxer: muxers return error codes, and AVERROR_EOF, despite being negative, is not an error. But in the end, you are right that the reasons given here make this patch wrong. Regards, --=20 Nicolas George --50etQCyVRUW0eDys Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE6ooRQGBoNzw0KnwPcZVLI8pNxgwFAmRG6Y8ACgkQcZVLI8pN xgzbZw/+OdJU39Nnba1VnrU7nTJzEDQaVCskiPYIeZaeHOR0u7iMQv3YYICKAunh caihScCB4s5+hs8sjTFETk9ggI2KiEeYEKZ51CyYLqwM3W4/W4ukdMvl8ywEd9JN j//SV7u8AdlGREuSeKguYNBWUzqRTupdlq6pK6P8VOAhapXCd4uXDyP3UV4qEAYE 9IlmCk4oOEUZJffqKpulQvyxVhlbmSoJ56VOWOHs8KkOjwyfsAMkP9nWS9ZJHaPO ytLUgPmQi/yhszlHcS3uRB29NqcS/8GwjAc2IxY54e2WoW1TGQFZcfZFIGSYbmV9 KcNRypJ+3ffXu0QZMiGNaleQs0HDYE+Y+XMSgoA7477HAFY3cVO8fa8r9qN3Eyh/ nzcHNuoKyVZA86UGApIAJh0tZOQBgQTonx+Nz6qXY+j59s6oRZCihfs+J7dja0Fj tccZPbQTWa+vFVwHZ/7D3zO07RbUatkDIVVsuBiW/KQKyf8GwGpBHOovJ9vnXLFy iKtlNEomHxkCutDYjIE5NoFkVJyU/uGlrL0N2Cy1oKuPf5OCHSyYS36jOH3WO7Sa auWbHneQnshM0vD24OBCbugDGS5r0ZSRfJpP7yeo+cOhuMG4XCWtXXjWDCAUq79F SB3k/9GgeDj3Qxcb/rDOdAfkFQwYY4R9v0uuo6oWghJcudF7jjo= =QxQb -----END PGP SIGNATURE----- --50etQCyVRUW0eDys-- --===============5045482701853277960== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============5045482701853277960==--