From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3045445828 for ; Mon, 24 Apr 2023 18:32:00 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 849F168BE0B; Mon, 24 Apr 2023 21:31:56 +0300 (EEST) Received: from nef.ens.fr (nef2.ens.fr [129.199.96.40]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 70103689E65 for ; Mon, 24 Apr 2023 21:31:50 +0300 (EEST) X-ENS-nef-client: 129.199.129.80 ( name = phare.normalesup.org ) Received: from phare.normalesup.org (phare.normalesup.org [129.199.129.80]) by nef.ens.fr (8.14.4/1.01.28121999) with ESMTP id 33OIVnbB025441 for ; Mon, 24 Apr 2023 20:31:49 +0200 Received: by phare.normalesup.org (Postfix, from userid 1001) id 9514FEB5BF; Mon, 24 Apr 2023 20:31:49 +0200 (CEST) Date: Mon, 24 Apr 2023 20:31:49 +0200 From: Nicolas George To: FFmpeg development discussions and patches Message-ID: References: <20230419195243.2974-1-anton@khirnov.net> <20230419195243.2974-23-anton@khirnov.net> <168233503763.3843.15441944598302423310@lain.khirnov.net> <168233747463.3843.6914979374280115185@lain.khirnov.net> <168233804222.3843.2176038618353077915@lain.khirnov.net> <168233943029.9711.17568532350489119659@lain.khirnov.net> MIME-Version: 1.0 In-Reply-To: <168233943029.9711.17568532350489119659@lain.khirnov.net> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (nef.ens.fr [129.199.96.32]); Mon, 24 Apr 2023 20:31:49 +0200 (CEST) Subject: Re: [FFmpeg-devel] [PATCH 23/25] fftools/ffmpeg_filter: add filtergraph private data X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============5300286880385198777==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============5300286880385198777== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="vUN3g8ugWbHqWCx4" Content-Disposition: inline --vUN3g8ugWbHqWCx4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Anton Khirnov (12023-04-24): > So when I wanted to make changes to libavfilter recently, you claimed > your familiarity with the code makes you more qualified to judge > readability. Now my familiarity with the code makes me LESS qualified. > Curious. There is a difference between long-term knowledge of a large part of the code and a short-term acquaintance with a limited slice of the code, I hope you realize. > We've also been moving private state to private data for many years now > and none of your conjectured concerns materialized, to the contrary code > became easier to maintain. Untrue. For example, every instance of FFFormatContext in the code gives places where the code has become that much more annoying to maintain. Maybe the same code has become more maintainable at the same time due to other changes, but the fact remains that these changes make it harder to work on the code. > Now that would be pure noise. The only noise here is all the fgp_from_fg() you want to liter over the code and the extra variables it requires. > I have no idea what are you even objecting to. What is even > controversial about not exposing state that does not need to be exposed? I have explained time and again: I oppose to any change that requires us to remember or check which structure a given field belongs to when it is not already obvious by its semantic. And again, there is nothing exposed to hide here. --=20 Nicolas George --vUN3g8ugWbHqWCx4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE6ooRQGBoNzw0KnwPcZVLI8pNxgwFAmRGyxMACgkQcZVLI8pN xgxhAhAAr+zt4GzP0/thfUM9HA/KP8p+1Ojvt/ISuUSXuGLxq3z0A2RHBtS1ZIrX H9gG8JEQi6FUY50JwVatqkXPOL/4K4LW61W9yPx9t2Dtzt5DkQFpcqHIlqC27lKa Rx7WyEoQxGszQ2HFQ7zL1b7W89yNA7RKSv/oYfNASG2T4UnE+afWQyQO4QYHectp ttRlKYlLjm8nVgkUKUPKhWrU0fSnCA05H0e1X8gq+PADZimINA7aYhUBy4oF1zXX eJbof6fodMr8JHCyfpfgdATuK++fwvOy4x+eODB4VBlbIP7rBTqOEaEpioiDHPda ycqPLVnfUHOjENadcrACOom1t6GPFvbV7qMuk3gW45mFPk82kDkIHYvaEVTtr2/2 fu+9aof/3MICRFOhvhkqvG45Walydu3OZ+yzcegZbTu+LlYxxpXry655FZ6FGUh/ 76vyi8wCOd9LTN9P21DzD7lPftt0n9iPZZ9um97Ia87GV1BCjlE3dm9UFKp6CVqA FbSG3CsStsDE6HbnpYiKfksOlitWlDhyf3z6Ce8ntkNG21jYA8b8yl/rLx1G0rL6 jjkJzHdMwWZicuLF2VjagRxm+kaA+Ml+8c1KUxQhocwvZkUyIdU7cT98WvTjylg2 4/C8t1rlNi/W76q0WMbTWtcylukKRA6Rv62zpi+NQieQKu0P4jg= =X8ct -----END PGP SIGNATURE----- --vUN3g8ugWbHqWCx4-- --===============5300286880385198777== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============5300286880385198777==--