From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id DE8F545BB1 for ; Mon, 24 Apr 2023 12:13:56 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3B12268BF7F; Mon, 24 Apr 2023 15:13:53 +0300 (EEST) Received: from nef.ens.fr (nef2.ens.fr [129.199.96.40]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C1E3368BED3 for ; Mon, 24 Apr 2023 15:13:46 +0300 (EEST) X-ENS-nef-client: 129.199.129.80 ( name = phare.normalesup.org ) Received: from phare.normalesup.org (phare.normalesup.org [129.199.129.80]) by nef.ens.fr (8.14.4/1.01.28121999) with ESMTP id 33OCDkDS015552 for ; Mon, 24 Apr 2023 14:13:46 +0200 Received: by phare.normalesup.org (Postfix, from userid 1001) id 08840EB5BF; Mon, 24 Apr 2023 14:13:45 +0200 (CEST) Date: Mon, 24 Apr 2023 14:13:45 +0200 From: Nicolas George To: FFmpeg development discussions and patches Message-ID: References: <20230419195243.2974-1-anton@khirnov.net> <20230419195243.2974-23-anton@khirnov.net> <168233503763.3843.15441944598302423310@lain.khirnov.net> <168233747463.3843.6914979374280115185@lain.khirnov.net> <168233804222.3843.2176038618353077915@lain.khirnov.net> MIME-Version: 1.0 In-Reply-To: <168233804222.3843.2176038618353077915@lain.khirnov.net> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (nef.ens.fr [129.199.96.32]); Mon, 24 Apr 2023 14:13:46 +0200 (CEST) Subject: Re: [FFmpeg-devel] [PATCH 23/25] fftools/ffmpeg_filter: add filtergraph private data X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============4839490626986834458==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============4839490626986834458== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="bYjkn1UEHcs6JjEU" Content-Disposition: inline --bYjkn1UEHcs6JjEU Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Anton Khirnov (12023-04-24): > What exactly is less readable? One variable gets its scope reduced, that > is a win in my book. Having to remember if a field is in structure x or structure y s a net loss that you do not see only because you just wrote the code and have everything freshly in mind. > And obviously I'm not stopping there, other things > will be moved to this private struct in future patches, Then move them into FilterGraph itself. If at some point later it makes sense to separate this structure to make the code clearer, we can do it at that time. If it happens, I predict the split will not be along the same =E2=80=9Cpublic=E2=80=9D/=E2=80=9Cprivate=E2=80=9D distinction you are= trying to make right now. > I just prefer to > avoid giant patchsets when possible. Yes, please do, giant patchsets are rude. > Also note that exactly the same pattern is used in ffmpeg_demux, > ffmpeg_mux, and ffmpeg_enc (and soon in ffmpeg_dec). If I had noticed it at the time, I would have objected the same way. --=20 Nicolas George --bYjkn1UEHcs6JjEU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE6ooRQGBoNzw0KnwPcZVLI8pNxgwFAmRGcngACgkQcZVLI8pN xgyANg//QC/Pg/QyR6r0qFMos/fWt6uR543t4iTDI9VZ02r1K16pjAMG2Po5o+WZ QFxDvNP6j3b6/h0nyDmISru0IbEhiAKH+FeLfFJV7GYgCFZF858gQ03YvUpDeLox A6BIWzF+Ev58YETIbJa5FfNZnRWBol6i4RjmB/sQg5FSX/w6sV/pOKfpGdsOKO1m FPQC0sPnGO30l5GTiOFSkTOv4t9wckxXIkI3DRQPjFac5eh/JctsfcvgGeUp5HDn 4p7Yi0yKCz8UXpKSimlPN7R2upzcYrT5k7my6r7b6eMGN6WwEqyMBBslrJQoX8PK T6i03KJiUvPKG1NSN5TDHNCvfQY9M56Jx85K9E4ps33HlHXGbTLHrnBno2CR2oju HCpw3JU5gQ6PE7c8haNBj0gCTcRrk0WcFNnLbqEz7896GUytIohf/QEDuuZkXZp0 R3EVYTRQzZg52FdKOy5q5MYkpfifH+7sy+gh8c05Gxwb7Fgf/8/+O2bfwd6ujVRC EXCz/Hy11JH0WYdYy2F+GtIMhLrBU3esQQf4PnuYa8/F9yUfLYVp1DI/WBmmjFdF BOvEcO47ga7HuwbDSdbuRSRVHcKNZuMTaQBBjjNqbAJYvtr38Vu66ben31kyr7u8 OnBlWWcwBEES/ips4DrcM8EBgbYMcbBPw9GoQdpv2rMA0+6xFAw= =+uhv -----END PGP SIGNATURE----- --bYjkn1UEHcs6JjEU-- --===============4839490626986834458== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============4839490626986834458==--