Re: [FFmpeg-devel] [PATCH 23/25] fftools/ffmpeg_filter: add filtergraph private data

[Nicolas George <george@nsup.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1059 bytes --]

Anton Khirnov (12023-04-24):
> What exactly is less readable? One variable gets its scope reduced, that
> is a win in my book.

Having to remember if a field is in structure x or structure y s a net
loss that you do not see only because you just wrote the code and have
everything freshly in mind.

>			And obviously I'm not stopping there, other things
> will be moved to this private struct in future patches,

Then move them into FilterGraph itself. If at some point later it makes
sense to separate this structure to make the code clearer, we can do it
at that time. If it happens, I predict the split will not be along the
same “public”/“private” distinction you are trying to make right now.

>							  I just prefer to
> avoid giant patchsets when possible.

Yes, please do, giant patchsets are rude.

> Also note that exactly the same pattern is used in ffmpeg_demux,
> ffmpeg_mux, and ffmpeg_enc (and soon in ffmpeg_dec).

If I had noticed it at the time, I would have objected the same way.

-- 
  Nicolas George

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".