From: Moritz Barsnick <barsnick@gmx.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] avformat/mxfenc: reject unsupported ffv1 versions
Date: Tue, 11 Apr 2023 23:49:15 +0200
Message-ID: <ZDXV20gMEZkUESJP@moonlight> (raw)
In-Reply-To: <20230405225044.DEFF3410810@natalya.videolan.org>
On Wed, Apr 05, 2023 at 22:50:43 +0000, Jerome Martinez wrote:
> ffmpeg | branch: master | Jerome Martinez <jerome at mediaarea.net> | Tue Apr 4 16:57:03 2023 +0200| [feeeefc3db04810286cd647f235ced0ec6c3eba8] | committer: Michael Niedermayer
>
> avformat/mxfenc: reject unsupported ffv1 versions
>
> Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
>
> > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=feeeefc3db04810286cd647f235ced0ec6c3eba8
> ---
>
> libavformat/mxfenc.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c
> index 9eba208ffb..d8252ed68f 100644
> --- a/libavformat/mxfenc.c
> +++ b/libavformat/mxfenc.c
> @@ -2493,6 +2493,10 @@ static int mxf_parse_ffv1_frame(AVFormatContext *s, AVStream *st, AVPacket *pkt)
> if (v > 4) {
> return 0;
> }
> + if (v > 4) {
> + av_log(s, AV_LOG_ERROR, "unsupported ffv1 version %d\n", v);
> + return 0;
> + }
> sc->micro_version = get_ffv1_unsigned_symbol(&c, state);
You inserted unreachable code.
Cheers,
Moritz
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
parent reply other threads:[~2023-04-11 21:49 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20230405225044.DEFF3410810@natalya.videolan.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZDXV20gMEZkUESJP@moonlight \
--to=barsnick@gmx.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git