From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 5B8224C37F for ; Sat, 8 Mar 2025 19:30:30 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 483F468E723; Sat, 8 Mar 2025 21:30:27 +0200 (EET) Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B6261680267 for ; Sat, 8 Mar 2025 21:30:20 +0200 (EET) Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-abf64aa2a80so563730966b.0 for ; Sat, 08 Mar 2025 11:30:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741462220; x=1742067020; darn=ffmpeg.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=tve5vPtbkDyxnKr1/JpclhFs5dnN62cOwz3m0HPf0eg=; b=SmkqETaaxINjglq+IQyGMfF5QyJTkPrq0/5wZmA0X4Lkz7RVv1t92FTg0IGF6Ur3Hb dMkcz8JpanMXrFGpjHsdoL0Yq0m4ES6c31caZ+Lkca6cYrNZ3756/bljT0jN6NjXPhYX oqQRC9RxN4RgG53bw4TK5Ry9h5BeiMv0MOShpItnZEkOiq2fcsY76ZRT4lagHk3ITa4i RdEWW0K7r7RUOSb8Ekof2mEgUC/xtJB0htLPArSuQ1fMIqWkjboGHZ3+++mUp1hPIuXW lgSp/1vlg+2Jx0sqyRFHmVfdalHjN3HSUMLLZvLbIdVvKP7jUDSl4iCJuTUtrP5mSDff LfNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741462220; x=1742067020; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tve5vPtbkDyxnKr1/JpclhFs5dnN62cOwz3m0HPf0eg=; b=A7j6VYg9y/DCvEi5Cd11KW3+HhZyiRbqQZCubzTby6/an/HzgC78p2DfE+/utl5WvM qZtLiRRzQszyNL1EO/C3RfR2pmTRu5qjXKT0kXbdduPjbE6DBL3HEOPnpNuaLmIcAqKO yggbIWTPkJ/n4ZTTfO7UGcpxGeojGar1v0C2ufmruVNNi9UoXMOv1kKsU1AH5ng5nqdB 2PENMRxW541ffnfe5aPZX598VkajV9MiZ65/KAKn+795qr5E95MIJRZFBLdc7vb8wNA2 VPd/Ir3d9cqBR3LNlfy1kz+KXIaQU+t4SRDLXB2wa8NFnm78Ixpq8rwO/MqU2pT0aUc1 uTeA== X-Gm-Message-State: AOJu0YynV2LwEy6dPI7qix6cda7FnbGUo2tEPg35o38JuhthCY9oJ2DB SIedRjnSTMVD1DAdDNl0OgAh/RqI2PFgNyeDA36+p3vku9GAq79JjVwxwg== X-Gm-Gg: ASbGncuA43G/LALDU2IMKIQLOht32QfmwQungNpWeyIMM80Y6RVKT+2sM0GiQJkiazH VxlCETfRNMvgyqQt0QyWG1HXTPjx0SYj95/y1I7l2Mm3OdG4YOk/pZZoeg1C3fK6414K0g+ts9O /HizkOXYnTFUDn6KqgRuVWPlyy076chZ6S3S92oexUOQQHxOoyCWnjgP8zQXp/XBuua430zItGq jl/EhjV4MLhFdYrXAw+Qq0yd+xS/bfw8muMsAu5VhuRNC4CAsE5y2h3Tt4MoR1mwCr2oc/EBKoq z5co018iwIjQcr94cFgU1gcSuJuDMdnCgkCXGFWNorc9xcUz3OdluFAHn6I4ofiWA0ljrYDvmWx XdXCcQipm X-Google-Smtp-Source: AGHT+IGF2OinAEPzmJgcqAWXZtf4L25giujFRwzNKJqSw5cvMZZzHjIjmc4kfqi2Fzmrsj4pWjGGAQ== X-Received: by 2002:a17:907:7e9c:b0:ac2:4d80:232a with SMTP id a640c23a62f3a-ac252b878demr793411766b.32.1741462219446; Sat, 08 Mar 2025 11:30:19 -0800 (PST) Received: from mariano (dynamic-adsl-84-220-189-10.clienti.tiscali.it. [84.220.189.10]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ac2399c9a79sm472358766b.162.2025.03.08.11.30.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Mar 2025 11:30:19 -0800 (PST) Received: by mariano (Postfix, from userid 1000) id E8620BFCE8; Sat, 8 Mar 2025 20:30:16 +0100 (CET) Date: Sat, 8 Mar 2025 20:30:16 +0100 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches , softworkz References: <61dc171fa16ea7d4b5d92f41072e385648a5be68.1741456535.git.ffmpegagent@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <61dc171fa16ea7d4b5d92f41072e385648a5be68.1741456535.git.ffmpegagent@gmail.com> User-Agent: Mutt/2.1.4 (2021-12-11) Subject: Re: [FFmpeg-devel] [PATCH v5 8/8] fftools/ffprobe: Rename AVTextFormatContext variables (w => tc) X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: softworkz Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Typo in the subject line (should be "tfc"). On date Saturday 2025-03-08 17:55:35 +0000, softworkz wrote: > From: softworkz > > Signed-off-by: softworkz > --- > fftools/ffprobe.c | 534 +++++++++++++++++++++++----------------------- > 1 file changed, 267 insertions(+), 267 deletions(-) > > static int opt_show_optional_fields(void *optctx, const char *opt, const char *arg) > @@ -3052,7 +3052,7 @@ static inline int check_section_show_entries(int section_id) > int main(int argc, char **argv) > { > const AVTextFormatter *f; > - AVTextFormatContext *tctx; > + AVTextFormatContext *tfc; I'd drop this rename since it introduces a greater asymmetry. > AVTextWriterContext *wctx; > char *buf; > char *f_name = NULL, *f_args = NULL; > @@ -3147,21 +3147,21 @@ int main(int argc, char **argv) > if (ret < 0) > goto end; > > - if ((ret = avtext_context_open(&tctx, f, wctx, f_args, > + if ((ret = avtext_context_open(&tfc, f, wctx, f_args, > sections, FF_ARRAY_ELEMS(sections), show_value_unit, > use_value_prefix, use_byte_value_binary_prefix, use_value_sexagesimal_format, > show_optional_fields, show_data_hash)) >= 0) { > if (f == &avtextformatter_xml) > - tctx->string_validation_utf8_flags |= AV_UTF8_FLAG_EXCLUDE_XML_INVALID_CONTROL_CODES; > + tfc->string_validation_utf8_flags |= AV_UTF8_FLAG_EXCLUDE_XML_INVALID_CONTROL_CODES; > > - avtext_print_section_header(tctx, NULL, SECTION_ID_ROOT); > + avtext_print_section_header(tfc, NULL, SECTION_ID_ROOT); > > if (do_show_program_version) > - ffprobe_show_program_version(tctx); > + ffprobe_show_program_version(tfc); > if (do_show_library_versions) > - ffprobe_show_library_versions(tctx); > + ffprobe_show_library_versions(tfc); > if (do_show_pixel_formats) > - ffprobe_show_pixel_formats(tctx); > + ffprobe_show_pixel_formats(tfc); > > if (!input_filename && > ((do_show_format || do_show_programs || do_show_stream_groups || do_show_streams || do_show_chapters || do_show_packets || do_show_error) || > @@ -3171,20 +3171,20 @@ int main(int argc, char **argv) > av_log(NULL, AV_LOG_ERROR, "Use -h to get full help or, even better, run 'man %s'.\n", program_name); > ret = AVERROR(EINVAL); > } else if (input_filename) { > - ret = probe_file(tctx, input_filename, print_input_filename); > + ret = probe_file(tfc, input_filename, print_input_filename); > if (ret < 0 && do_show_error) > - show_error(tctx, ret); > + show_error(tfc, ret); > } > > input_ret = ret; > > - avtext_print_section_footer(tctx); > + avtext_print_section_footer(tfc); > > ret = avtextwriter_context_close(&wctx); > if (ret < 0) > av_log(NULL, AV_LOG_ERROR, "Writing output failed (closing writer): %s\n", av_err2str(ret)); > > - ret = avtext_context_close(&tctx); > + ret = avtext_context_close(&tfc); > if (ret < 0) > av_log(NULL, AV_LOG_ERROR, "Writing output failed (closing formatter): %s\n", av_err2str(ret)); Should be good otherwise, thanks. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".