From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ffmpeg-devel-bounces@ffmpeg.org> Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id D8CAB4C34B for <ffmpegdev@gitmailbox.com>; Sat, 8 Mar 2025 19:08:47 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0883468E66F; Sat, 8 Mar 2025 21:08:44 +0200 (EET) Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A180268DFB0 for <ffmpeg-devel@ffmpeg.org>; Sat, 8 Mar 2025 21:08:37 +0200 (EET) Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-43bd5644de8so31844255e9.3 for <ffmpeg-devel@ffmpeg.org>; Sat, 08 Mar 2025 11:08:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741460917; x=1742065717; darn=ffmpeg.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=XQ+x89kyy1hspV4rkdNn/WV3YajZ/UJ3HY1cV8hs4EU=; b=gDfVvT2vsoedYaF2rqAZ19gc1g4PgQYHUROK+9yKW3bswWcUNSYhsr4+lAWEqOBOCk O1MFt0bU2FulHqXlx9SMvWaIXVpQPiXvvBvpWiZTZH10ebq5UVT/XBpctgdRgMvFa500 4thGRl3XMDRXblwdq4lDdvuoh3t2O0eaX2xX+lN7ojvUoBVJ9khG3zb0+Rto0fcqmhOa a6X05I3avRLShrYq+u2AWfsjajsNYuHxYAYV4kGy1QvwZByXUNj3dRfCkE8hSJa6B5k3 v8MoU6FLb0nobIaOxcHEHO8/lBSOjGjY+pbhc1+WtD/156nKOSpy4OLsq6g93efJSFY2 Mysw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741460917; x=1742065717; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XQ+x89kyy1hspV4rkdNn/WV3YajZ/UJ3HY1cV8hs4EU=; b=D4z9m2b4OuJ3YyKj3t+FvLBSceAJwCng+PpTxOWzxl/ZF8ezIS4Wo2N+le6ARdYbyH CVnhtkmNJPYO4n6ILV8hK6fTWbu+tySf8DSdCz/0EtQE9r6oGu21AIpzzKVIqTGTEDmk oSznnXoytkzfDNk/ersHDDtPUBlpyP9mR+ABXb5W7j9MFGNeF3nwEMsOdnTjGpuft2og flA3csvhcTHjZMMXmAChD2j6G1JKHesZsO/0WimTCi48Y+gL9hrKI8bzUJDiXIwA23Iv X7mjWHq716oIziEgWvq/+U2Q2SV/KZgPDOQwIIvjCCcOh8yfYxId3ZnnbvkLxOJQX8M8 tk7g== X-Gm-Message-State: AOJu0YyukwdksTMyOJ1JTetGBbxK0e/+KA/n6zpqUV+4+aBldI17evkM eejF7FZgAfgUyJXEj6wox5tScCmwPhfeo2hO9f47OCx80ndzQ+wVU/3KJA== X-Gm-Gg: ASbGncvo6DE3lMCa0dSWGesHQu914veVUxawpefN+KxzyOOdlTnYrRbIYtqptzjhRvH 9XhfcmRIwaP1k6/Kbl9DoQ6FfJSGRk3Gcs7J5IvRos/yAFqO3S90SaQCaA9z4f+Ti8qqGLx+Icd 7nN3+XMnUiTKv3/p7NiCfE9Q9petLtNk6gTuCqmteWsJj9Fcezf8qIQouJHsBayOHLJS9SgCoI4 pLFYdGp8C1H3MmqUTp+nxoMF5Cy4SyoJGd6wMoMTdogYzI3h76yoBdHOuwxK6RC2ZSuuW/MB8WV /2AhFUE8QtguDAYHZaM+IIBZpdAt59OGL+Qz0epXSdw4iBI4X/iCPfeWBl6LrIkQS+L84ab/Heo vgI2W53ZX X-Google-Smtp-Source: AGHT+IFBl6cRJ+BID11te8UBE8qHEM7HvS7AtZr2QRNGTSFHdnFAWLjbkqHY1H6rWhSwT3Wo1f+dww== X-Received: by 2002:a5d:47cd:0:b0:391:952:c730 with SMTP id ffacd0b85a97d-39132d09078mr7055212f8f.11.1741460916501; Sat, 08 Mar 2025 11:08:36 -0800 (PST) Received: from mariano (dynamic-adsl-84-220-189-10.clienti.tiscali.it. [84.220.189.10]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3912c0e34fasm9682506f8f.75.2025.03.08.11.08.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Mar 2025 11:08:35 -0800 (PST) Received: by mariano (Postfix, from userid 1000) id 1A04EBFCE8; Sat, 8 Mar 2025 20:08:33 +0100 (CET) Date: Sat, 8 Mar 2025 20:08:33 +0100 From: Stefano Sabatini <stefasab@gmail.com> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Message-ID: <Z8yVsYWavdUm230j@mariano> Mail-Followup-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>, softworkz <softworkz-at-hotmail.com@ffmpeg.org> References: <pull.52.v4.ffstaging.FFmpeg.1740869691.ffmpegagent@gmail.com> <pull.52.v5.ffstaging.FFmpeg.1741456535.ffmpegagent@gmail.com> <b26a45ea0e84c39a75de607789833be79bba2f5a.1741456535.git.ffmpegagent@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <b26a45ea0e84c39a75de607789833be79bba2f5a.1741456535.git.ffmpegagent@gmail.com> User-Agent: Mutt/2.1.4 (2021-12-11) Subject: Re: [FFmpeg-devel] [PATCH v5 1/8] fftools/textformat: Extract and generalize textformat api from ffprobe.c X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org> List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe> List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel> List-Post: <mailto:ffmpeg-devel@ffmpeg.org> List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help> List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe> Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Cc: softworkz <softworkz@hotmail.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org> Archived-At: <https://master.gitmailbox.com/ffmpegdev/Z8yVsYWavdUm230j@mariano/> List-Archive: <https://master.gitmailbox.com/ffmpegdev/> List-Post: <mailto:ffmpegdev@gitmailbox.com> On date Saturday 2025-03-08 17:55:28 +0000, softworkz wrote: > From: softworkz <softworkz@hotmail.com> > > Signed-off-by: softworkz <softworkz@hotmail.com> > --- > fftools/textformat/avtextformat.c | 672 +++++++++++++++++++++++++++++ > fftools/textformat/avtextformat.h | 171 ++++++++ > fftools/textformat/avtextwriters.h | 68 +++ > fftools/textformat/tf_compact.c | 282 ++++++++++++ > fftools/textformat/tf_default.c | 145 +++++++ > fftools/textformat/tf_flat.c | 174 ++++++++ > fftools/textformat/tf_ini.c | 160 +++++++ > fftools/textformat/tf_json.c | 215 +++++++++ > fftools/textformat/tf_xml.c | 221 ++++++++++ > fftools/textformat/tw_avio.c | 129 ++++++ > fftools/textformat/tw_buffer.c | 92 ++++ > fftools/textformat/tw_stdout.c | 82 ++++ > 12 files changed, 2411 insertions(+) > create mode 100644 fftools/textformat/avtextformat.c > create mode 100644 fftools/textformat/avtextformat.h > create mode 100644 fftools/textformat/avtextwriters.h > create mode 100644 fftools/textformat/tf_compact.c > create mode 100644 fftools/textformat/tf_default.c > create mode 100644 fftools/textformat/tf_flat.c > create mode 100644 fftools/textformat/tf_ini.c > create mode 100644 fftools/textformat/tf_json.c > create mode 100644 fftools/textformat/tf_xml.c > create mode 100644 fftools/textformat/tw_avio.c > create mode 100644 fftools/textformat/tw_buffer.c > create mode 100644 fftools/textformat/tw_stdout.c Looks good to me. As I said, there are a few API tweaks we might want to apply to improve overall consistency and usability, but it is not blocking from my side given this is internal API. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".