Re: [FFmpeg-devel] [PATCH v3 3/7] fftools/ffprobe: Rename writer_print_section_* and WriterContext

[Stefano Sabatini <stefasab@gmail.com>]

On date Saturday 2025-03-01 10:02:00 +0000, softworkz wrote:
> From: softworkz <softworkz@hotmail.com>
> 
> separated for better clarity of the preceding commit
> 
> Signed-off-by: softworkz <softworkz@hotmail.com>
> ren
> ---
>  fftools/ffprobe.c | 361 +++++++++++++++++++++++-----------------------
>  1 file changed, 178 insertions(+), 183 deletions(-)
> 
> diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c
> index f398057df7..4a90bc4824 100644
> --- a/fftools/ffprobe.c
> +++ b/fftools/ffprobe.c
> @@ -71,11 +71,6 @@
>  
>  #include "libavutil/thread.h"
>  
> -// TEMPORARY DEFINES
> -#define writer_print_section_header(w, d, s) avtext_print_section_header(w, d, s)
> -#define writer_print_section_footer(w) avtext_print_section_footer(w)
> -#define WriterContext AVTextFormatContext
> -
>  // attached as opaque_ref to packets/frames
>  typedef struct FrameData {
>      int64_t pkt_pos;
> @@ -446,25 +441,25 @@ static void log_callback(void *ptr, int level, const char *fmt, va_list vl)
>      memset( (ptr) + (cur_n), 0, ((new_n) - (cur_n)) * sizeof(*(ptr)) ); \
>  }
>  

> -static inline int show_tags(WriterContext *w, AVDictionary *tags, int section_id)
> +static inline int show_tags(AVTextFormatContext *w, AVDictionary *tags, int section_id)

maybe while at it also change w to f or t?

again this might be done as a patch on top, or there be will wondering
readers

[...]

Should be good otherwise.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".