From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTPS id 7410D4E06D
	for <ffmpegdev@gitmailbox.com>; Sat,  8 Mar 2025 14:36:53 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 87AB768F3DE;
	Sat,  8 Mar 2025 16:36:49 +0200 (EET)
Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com
 [209.85.221.46])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 05D3468D798
 for <ffmpeg-devel@ffmpeg.org>; Sat,  8 Mar 2025 16:36:38 +0200 (EET)
Received: by mail-wr1-f46.google.com with SMTP id
 ffacd0b85a97d-390f5f48eafso1466266f8f.0; 
 Sat, 08 Mar 2025 06:36:38 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1741444597; x=1742049397; darn=ffmpeg.org;
 h=user-agent:in-reply-to:content-disposition:mime-version:references
 :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc
 :subject:date:message-id:reply-to;
 bh=ooc62gwhzxYBOFsBWY47wKFuloFt+km4Qfps1ZNnEao=;
 b=cu850x1r1ctEut7QcKAC9T6+RZKr0aJNRGm6XYCGwJBtQROMVEG/4xT03kmGFypLpl
 SrLWYjZUmFVH9Kr++MTacfJB6XmmcvIz7qFEnPvDqabldA3YSUUSz19FHWaR1MN87pII
 ymKeqQqY9zcC4Hy4Ak3X/F2inQ77+QiXRmcdr3Ua4lsmw/1YMVOwapzMmuLX3vCKINLm
 0b31pFIEOS5adEeBrhv4vqH7syXkBoRr/7RZrQ01QYJhQhVigVljWw41vXOr0sA4m6hK
 5gQUDmsAeGPSo3aYrnIom9dM5r1Gjbp/nr5mq2POBgeSLaUcR6vgEraBM1BjXG4ySvax
 yrKQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1741444597; x=1742049397;
 h=user-agent:in-reply-to:content-disposition:mime-version:references
 :mail-followup-to:message-id:subject:cc:to:from:date
 :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
 bh=ooc62gwhzxYBOFsBWY47wKFuloFt+km4Qfps1ZNnEao=;
 b=wX0DcEZhxE0MWv4odMmSZEsi3YMjX1UL9diwaS0+CR3RkpLaUQe7XiIvZ9RkUH+C4V
 SkrPrKUMlJ4vC2kFHwAAy9BBH3czQalmhSWCtIl3+N7BFvRbXJURR80NiqULNTjzenBL
 tz+4kjlA7gFfJlJqnUxKX0saKCn2msr9+pRpk2yOCYcfIuYoytxMszPqcwo2LrbXRTOk
 W7/utwpjecwonfOAnKv5uhQyYpyCgmM/SoHUcdgWPfLXQstBn9E6pFIrEx4PktNNI2u6
 BF1uUph+wZH4kcNE6CSL8H3xEiSX7DMiuHjSa+xGrQzK/fQZi6kwSzX2xzONZ88eFi1P
 sWEA==
X-Gm-Message-State: AOJu0YwHjwivIjw+DF2ZmUVVBVSIxXiEOJnOBXB/iLgKyZTqD3T+DPi1
 AcsdZ0Td4tKkT02fQLr+bYqLTJZKEL6g2VLY5xgi54x+TR/hq8cQLKSLgA==
X-Gm-Gg: ASbGncvQ7LyH0taBXDwpcvE/0mxi2HutFradXMm5CIZ+1rdLc/0kHA5SFTjWSL+O4gB
 h7xhvYLjBoT0OYN9UorTQ/2+OQVVczZ29M7bFGyC8pmK6GCdHXKxIoiswx9vbm3bqEcOgz1jUxl
 bI/5FWgWwjp3W/vYdVhe80ManBx9/GfRCZ54iHGjoGmt2H8HAZyLkBAvqFT60CdCNwb3QD9D7/4
 CPg3K2p+9u6b2NMXyqgniZ2cr7T6JswqICy7sstj2nub8Cj1DOOtBTqzItxSae1AO56NQ8E5hCJ
 j6vxmYsNEvD3MQF5sCVZnA28domaHSH/C4HxR6K6OVXgue9qSX3adg/hzTg9+bkl4kPBvG5sQiA
 bcjYqoOVN
X-Google-Smtp-Source: AGHT+IFIadpd4TNYjjsKEkLY5TNvBGDGZpCIniBmWbXQbnZLgtRN6fFaECgqJP8d2ly51J/ajHvKzg==
X-Received: by 2002:a05:6000:1864:b0:391:39ea:7866 with SMTP id
 ffacd0b85a97d-39139ea7d93mr2937423f8f.19.1741444596872; 
 Sat, 08 Mar 2025 06:36:36 -0800 (PST)
Received: from mariano (dynamic-adsl-84-220-189-10.clienti.tiscali.it.
 [84.220.189.10]) by smtp.gmail.com with ESMTPSA id
 ffacd0b85a97d-3912bfbaa94sm9030398f8f.14.2025.03.08.06.36.36
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 08 Mar 2025 06:36:36 -0800 (PST)
Received: by mariano (Postfix, from userid 1000)
 id E6E3CBFCE8; Sat,  8 Mar 2025 15:36:34 +0100 (CET)
Date: Sat, 8 Mar 2025 15:36:34 +0100
From: Stefano Sabatini <stefasab@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Message-ID: <Z8xV8g1pb2RPTKw1@mariano>
Mail-Followup-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>,
	Soft Works <softworkz-at-hotmail.com@ffmpeg.org>,
	softworkz <softworkz-at-hotmail.com@ffmpeg.org>,
	Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
References: <pull.52.v2.ffstaging.FFmpeg.1740137232.ffmpegagent@gmail.com>
 <pull.52.v3.ffstaging.FFmpeg.1740823324.ffmpegagent@gmail.com>
 <6239813ba0e293bd427cecf8437aadef778ea3ee.1740823324.git.ffmpegagent@gmail.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <6239813ba0e293bd427cecf8437aadef778ea3ee.1740823324.git.ffmpegagent@gmail.com>
User-Agent: Mutt/2.1.4 (2021-12-11)
Subject: Re: [FFmpeg-devel] [PATCH v3 1/7] fftools/textformat: Extract and
 generalize textformat api from ffprobe.c
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Soft Works <softworkz-at-hotmail.com@ffmpeg.org>,
 softworkz <softworkz@hotmail.com>,
 Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/Z8xV8g1pb2RPTKw1@mariano/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

On date Saturday 2025-03-01 10:01:58 +0000, softworkz wrote:
[...]

> +int avtext_context_open(AVTextFormatContext **ptctx, const AVTextFormatter *formatter, AVTextWriterContext *writer, const char *args,
> +                        const struct AVTextFormatSection *sections, int nb_sections,
> +                        int show_value_unit,
> +                        int use_value_prefix,
> +                        int use_byte_value_binary_prefix,
> +                        int use_value_sexagesimal_format,
> +                        int show_optional_fields,
> +                        char *show_data_hash);

writer -> writer_ctx?

I'm fine with changing this later to avoid massive rebase edits.

Also I notice there is some of the usual inconsistencies here:
av_X_Y against avXY and avX_Y that we have in the rest of the code.

Maybe let's stick to avX_Y or to av_X_Y.

Also this might be:
av_text_format_open(...)
av_text_format_close(...)
av_text_format_print_X(...)

Or to simplify we can just call the structure AVTextContext (I see
text as an evolution of a string, meant for structured formatted data,
which is implied by the fact that we need a formatter) and simplify
related functions naming to:
av_text_open(...)
av_text_close(...)
av_text_print_X(...)

av_text_formatter_...
av_text_writer_open...
av_text_writer_close...

In fact I don't think there is much gain in keeping "context" in the
name of the functions.

What do you think?

Again, since this is not public API (yet?) this should not be
considered a blocker (also I've been out of touch with FFmpeg and I
might be not aware of API conventions evolution).
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".