From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ffmpeg-devel-bounces@ffmpeg.org> Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 3291C4E063 for <ffmpegdev@gitmailbox.com>; Sat, 8 Mar 2025 14:18:25 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0CA4568F3DB; Sat, 8 Mar 2025 16:18:22 +0200 (EET) Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BC39368F393 for <ffmpeg-devel@ffmpeg.org>; Sat, 8 Mar 2025 16:18:09 +0200 (EET) Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-38dcac27bcbso2575079f8f.0; Sat, 08 Mar 2025 06:18:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741443489; x=1742048289; darn=ffmpeg.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=1INVmeigfjs9QjRku8O/llMDA8tmG+oPmUURlmB34zA=; b=ecmHX1fHCRPfnttbv5nCn1c32QmwMMgfz2fhUpLnI6Kk7JopEZ0UtksZ52nu+omhNG vAhBZGkUlzIWp6H6xus6u/gyAznd2q33mQt7XmcEyX/RYFDjBhj17rZAi7LK6JmUijzm LRffDAXySOYD7ahHO5iPBHbxifmw4Y4wif7cI9oQZhk4xKTTARWhkyOYMJnVeK4u2k1Q TXRwhLTxP6nwm8LJkGuiqAXfojngZRTzYD8UYpdhh9FgBnOedTsc4TYzoLcmL7+/QbY8 Wug3XQtAnFngrMM1v7L8F+vdeLtNW6LJKkCiBwur0c5ri+ftc/HHjcrDrDfo+2TV8YXO ymNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741443489; x=1742048289; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1INVmeigfjs9QjRku8O/llMDA8tmG+oPmUURlmB34zA=; b=HbqPbggWqDbNYW5NQ2QvnU+YPi1hCIX1WUsuHmf6vfM+KNj1jpAt/RBq/dxisyNdlJ CMdp7bvHPUnuXo3gDDg1TAnfGTz6j/p0ygL/5Ennt721kGvt0poUXS3J7tCtGaw+UeQB YT/juEg7rvD8zoJJc8QHJqd1RMcU5pI/t1B1DAKsbm2eUL6BqqbKfNL6M8By+33VKHGM SfUEoYnsQxa1bv6zfxLNLiK0Z6gJT4Mx56HpFd5uGpENZqH5WswbZ/P7nYF9BS7Lrq6H YnXOHh9yrNbtOzvlNgzmZrtczSjjCx0R4dEXVtLgLAGuY7wp43ADSP6Awckq+KRAxmjK xtWA== X-Gm-Message-State: AOJu0Yzf4gLj8p/at/TsxC/rL9Zpk6MO8NrGcNxJIX6CFDcHiwr8EVNq L6lVBd5GkWdIsCgHh8oxEA8sBwq3TMILqbwH0bdDgoGJbDtXMrOyxT3zrw== X-Gm-Gg: ASbGncv0XyA6RZvASwUZbXSacsxyWMVBtFMw9OHAy8JyNLAh+6mWnNDiXerAEUwMtqg WyfTUwNm2lGaArPOunJkxmtS/ppmJg3pin+C6HSOQ7asXFZeEBP9vcDw643L/j209ooWgIkmmhZ kKBpopoigRkYS/NJTd/7BHSBR3g/uVmaL7on2/GZbBJaf2BJc8tuuahBgaM9Pt4qtKpudGGIEZB N2NDZM8Njs2jePFu+QJRNqtscW2QmE+d2WAHz/clI7CFynzLNk9wGM+UlGFxr3lCRgnm+virOCX L9wZXCnhJnPg8sM4tHIN23p8dJUz9ID1vzC/22Ck6HboOpTtekvZYBd+sjgCOOLP3tNO+2jeqS6 OTgzajr8rJq8zlEZfUQM= X-Google-Smtp-Source: AGHT+IE36XO+Y4vrtt52bsjz0jvTUoxsosO6D6oKH/k2o1wmJmG8r3d4xZHoYmJWTumytAWZGeURzQ== X-Received: by 2002:a05:6000:184b:b0:38f:23c4:208c with SMTP id ffacd0b85a97d-3913af2e472mr1905311f8f.18.1741443488487; Sat, 08 Mar 2025 06:18:08 -0800 (PST) Received: from mariano (dynamic-adsl-84-220-189-10.clienti.tiscali.it. [84.220.189.10]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3912c0e34fasm9008627f8f.75.2025.03.08.06.18.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Mar 2025 06:18:07 -0800 (PST) Received: by mariano (Postfix, from userid 1000) id 40122BFCE8; Sat, 8 Mar 2025 15:18:06 +0100 (CET) Date: Sat, 8 Mar 2025 15:18:06 +0100 From: Stefano Sabatini <stefasab@gmail.com> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Message-ID: <Z8xRnhXoenkAbu5G@mariano> Mail-Followup-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>, Soft Works <softworkz-at-hotmail.com@ffmpeg.org>, softworkz <softworkz-at-hotmail.com@ffmpeg.org>, Andreas Rheinhardt <andreas.rheinhardt@outlook.com> References: <pull.52.v2.ffstaging.FFmpeg.1740137232.ffmpegagent@gmail.com> <pull.52.v3.ffstaging.FFmpeg.1740823324.ffmpegagent@gmail.com> <805f66cd92febb5b753d4e352d4450dd584e7235.1740823324.git.ffmpegagent@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <805f66cd92febb5b753d4e352d4450dd584e7235.1740823324.git.ffmpegagent@gmail.com> User-Agent: Mutt/2.1.4 (2021-12-11) Subject: Re: [FFmpeg-devel] [PATCH v3 2/7] fftools/ffprobe: Change to use textformat api X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org> List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe> List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel> List-Post: <mailto:ffmpeg-devel@ffmpeg.org> List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help> List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe> Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Cc: Soft Works <softworkz-at-hotmail.com@ffmpeg.org>, softworkz <softworkz@hotmail.com>, Andreas Rheinhardt <andreas.rheinhardt@outlook.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org> Archived-At: <https://master.gitmailbox.com/ffmpegdev/Z8xRnhXoenkAbu5G@mariano/> List-Archive: <https://master.gitmailbox.com/ffmpegdev/> List-Post: <mailto:ffmpegdev@gitmailbox.com> On date Saturday 2025-03-01 10:01:59 +0000, softworkz wrote: > From: softworkz <softworkz@hotmail.com> > > Signed-off-by: softworkz <softworkz@hotmail.com> > --- > fftools/Makefile | 12 + > fftools/ffprobe.c | 1849 ++++----------------------------------------- > 2 files changed, 142 insertions(+), 1719 deletions(-) [...] Overall makes sense. I spotted a few weird indents and possibly a few patch un-related API inconsistencies I will treat in a separate thread, but overall I think this is fine and welcome. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".