From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ffmpeg-devel-bounces@ffmpeg.org> Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id D20E44DCD0 for <ffmpegdev@gitmailbox.com>; Sun, 2 Mar 2025 17:55:18 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4DC7368E1B2; Sun, 2 Mar 2025 19:55:13 +0200 (EET) Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BFA2668E13F for <ffmpeg-devel@ffmpeg.org>; Sun, 2 Mar 2025 19:55:02 +0200 (EET) Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4394a0c65fcso38945355e9.1; Sun, 02 Mar 2025 09:55:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740938102; x=1741542902; darn=ffmpeg.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=b7GgEjpkSNN9AUMl17xA71mJGLtON+6kv4Ftnm0d9BM=; b=RenuxZ+4tXlXwEnGCJzY+N9R6A5QPKNAnhDQ3/5u8Vfz0GdJydTHrGvSV1LidZ0TG4 q+5382Ff3w5d2yFYJdHZ883wiXJIpzHB2CdpPwcD/u47dW26FWsgpf9JB51hjJQDGWH8 bRYkLC15Dbm3/T5Cdl52EFQ+govCgZXkDfuqvsn9Rh4yc42/6KHKo/DNNt5CMGvnpCr2 zpePaQZVK7mA/UD0rrRIAHZ3GYQb1u6o1sE8JmZG10Qb29PrDvwFAkQG3GHK67YvVzx8 KO0wk+qYh9G8VZ89/S5Wg00Z9wkV//VLLlmgg0t4Qo8pekxQ3c5iHD72vvgCoukeH3HF xm9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740938102; x=1741542902; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=b7GgEjpkSNN9AUMl17xA71mJGLtON+6kv4Ftnm0d9BM=; b=jJ8e+2JpBwkRBmjMlWlT/132O/bl5MB+BKCL61dM62S63yb3emXMc1tC3RznO2Ykow CwHuUPaNGv5ZvWvIK30yaQar0aQF35NQS/SFGIRvb0y44xWT3eTDPWUmdjn7k2PnZ0wS nqJhRj72XcJ5+VnKZQeVrBi/VmNiy5u3h2jK1mb7bwD3moB3Ns4PTDzH+4YbWw5zhkX3 UIE6AoDb2FiOaRDKxCUgKk6u5/9YEFkiSH22xRFWVEBzTm2npkj9RsCF459MU86Y0X3b dsHdg5bASpEvNfRP8EsUvuvOVcgnMFb6F8dDJvDd4yl366KlAKaDoAn+DwFua/1kqrSC d+Cg== X-Gm-Message-State: AOJu0Yw5Gae+YtUFg89KymxB/6VB/H8Th3f3HGzOSEAsIvFeY/FBdR3b LuR6rjHg4FGXeXPqm43OeNli7vpKuU8U72P+4jjYyJvAAFf2F5nFmV8oqA== X-Gm-Gg: ASbGncsza2/VJ3kbDS/97V1ojYslxyL3DWwU0c0dG3hjeQMZL2XbbzY5Lr5UAnvGGCs /NxB0ujfB5uvE9sPVqnsb89yKPsCMg+IZ4801UTxZQXXpPBryTQ9kecav2qmJbaYsR3MdrWnZPa WaqOvH4492xJps5whke/IQ3ILc2mFa/VZ5KmZukSLOeEOLUIN8cNU2u2QFvqHgp5c1TeeGYg9eJ tVlkUF3SgBd6eRNI6MxwE3dB3JYmpFr//2HZ4Zz+d5nbzi3AOWCklHPpPrHJ1xryYvYtv8uldyg btrQLn0WER4lrfcUBa8oV3ZTAbvr4LMUB6t5WZxSqD+GoRqo97aOanjsCySAz0SkOzM+nGKl4zT RoB4rtNgT X-Google-Smtp-Source: AGHT+IFSQgD8GVpjTJDHus7NC1wEAm0CsIfTQbehkN7pvbP0DsGoogA+sr1W7ybMJr2w6JoFr+T6yA== X-Received: by 2002:a05:6000:178c:b0:390:debd:70c3 with SMTP id ffacd0b85a97d-390eca25fbdmr10693432f8f.54.1740938101495; Sun, 02 Mar 2025 09:55:01 -0800 (PST) Received: from mariano (dynamic-adsl-84-220-189-10.clienti.tiscali.it. [84.220.189.10]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43bbcd83914sm22306845e9.29.2025.03.02.09.55.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Mar 2025 09:55:00 -0800 (PST) Received: by mariano (Postfix, from userid 1000) id 6BF4EBFCE8; Sun, 2 Mar 2025 18:54:59 +0100 (CET) Date: Sun, 2 Mar 2025 18:54:59 +0100 From: Stefano Sabatini <stefasab@gmail.com> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Message-ID: <Z8Sbc6cDaKH0ydq4@mariano> Mail-Followup-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>, Soft Works <softworkz-at-hotmail.com@ffmpeg.org>, softworkz <softworkz-at-hotmail.com@ffmpeg.org>, Andreas Rheinhardt <andreas.rheinhardt@outlook.com> References: <pull.52.v2.ffstaging.FFmpeg.1740137232.ffmpegagent@gmail.com> <pull.52.v3.ffstaging.FFmpeg.1740823324.ffmpegagent@gmail.com> <6239813ba0e293bd427cecf8437aadef778ea3ee.1740823324.git.ffmpegagent@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6239813ba0e293bd427cecf8437aadef778ea3ee.1740823324.git.ffmpegagent@gmail.com> User-Agent: Mutt/2.1.4 (2021-12-11) Subject: Re: [FFmpeg-devel] [PATCH v3 1/7] fftools/textformat: Extract and generalize textformat api from ffprobe.c X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org> List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe> List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel> List-Post: <mailto:ffmpeg-devel@ffmpeg.org> List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help> List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe> Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Cc: Soft Works <softworkz-at-hotmail.com@ffmpeg.org>, softworkz <softworkz@hotmail.com>, Andreas Rheinhardt <andreas.rheinhardt@outlook.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org> Archived-At: <https://master.gitmailbox.com/ffmpegdev/Z8Sbc6cDaKH0ydq4@mariano/> List-Archive: <https://master.gitmailbox.com/ffmpegdev/> List-Post: <mailto:ffmpegdev@gitmailbox.com> Hi, I'll have a look at this in the week. There are a few things which I want to doublecheck (there is some ad-hoc application logic which might be broken when generalizing this), but I like the overall direction of this changeset. On date Saturday 2025-03-01 10:01:58 +0000, softworkz wrote: > From: softworkz <softworkz@hotmail.com> > > Signed-off-by: softworkz <softworkz@hotmail.com> > --- > fftools/textformat/avtextformat.c | 671 +++++++++++++++++++++++++++++ > fftools/textformat/avtextformat.h | 171 ++++++++ > fftools/textformat/avtextwriters.h | 68 +++ > fftools/textformat/tf_compact.c | 282 ++++++++++++ > fftools/textformat/tf_default.c | 145 +++++++ > fftools/textformat/tf_flat.c | 174 ++++++++ > fftools/textformat/tf_ini.c | 160 +++++++ > fftools/textformat/tf_json.c | 215 +++++++++ > fftools/textformat/tf_xml.c | 221 ++++++++++ > fftools/textformat/tw_avio.c | 129 ++++++ > fftools/textformat/tw_buffer.c | 92 ++++ > fftools/textformat/tw_stdout.c | 82 ++++ Not sure if this is ffmpeg-ish but we might move the formats within a dedicated subdirectory to make more apparent the core/components distinction - anyway this is not a blocker. [...] _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".