Re: [FFmpeg-devel] [PATCH v3 1/7] fftools/textformat: Extract and generalize textformat api from ffprobe.c

From: Stefano Sabatini <stefasab@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Soft Works <softworkz-at-hotmail.com@ffmpeg.org>,
	softworkz <softworkz@hotmail.com>,
	Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Subject: Re: [FFmpeg-devel] [PATCH v3 1/7] fftools/textformat: Extract and generalize textformat api from ffprobe.c
Date: Sun, 2 Mar 2025 18:54:59 +0100
Message-ID: <Z8Sbc6cDaKH0ydq4@mariano> (raw)
In-Reply-To: <6239813ba0e293bd427cecf8437aadef778ea3ee.1740823324.git.ffmpegagent@gmail.com>

Hi,

I'll have a look at this in the week. There are a few things which I
want to doublecheck (there is some ad-hoc application logic which
might be broken when generalizing this), but I like the overall
direction of this changeset.

On date Saturday 2025-03-01 10:01:58 +0000, softworkz wrote:
> From: softworkz <softworkz@hotmail.com>
> 
> Signed-off-by: softworkz <softworkz@hotmail.com>
> ---
>  fftools/textformat/avtextformat.c  | 671 +++++++++++++++++++++++++++++
>  fftools/textformat/avtextformat.h  | 171 ++++++++
>  fftools/textformat/avtextwriters.h |  68 +++

>  fftools/textformat/tf_compact.c    | 282 ++++++++++++
>  fftools/textformat/tf_default.c    | 145 +++++++
>  fftools/textformat/tf_flat.c       | 174 ++++++++
>  fftools/textformat/tf_ini.c        | 160 +++++++
>  fftools/textformat/tf_json.c       | 215 +++++++++
>  fftools/textformat/tf_xml.c        | 221 ++++++++++
>  fftools/textformat/tw_avio.c       | 129 ++++++
>  fftools/textformat/tw_buffer.c     |  92 ++++
>  fftools/textformat/tw_stdout.c     |  82 ++++

Not sure if this is ffmpeg-ish but we might move the formats within a
dedicated subdirectory to make more apparent the core/components
distinction - anyway this is not a blocker.

[...]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".