From: Nicolas George <george@nsup.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 2/3] fftools/ffmpeg_graphprint: Add options for filtergraph printing
Date: Mon, 24 Feb 2025 11:41:05 +0100
Message-ID: <Z7xMwa9MvBVhsEEW@phare.normalesup.org> (raw)
In-Reply-To: <DM8P223MB03656B321A0F7AF83C1732F9BAC72@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM>
Soft Works (HE12025-02-21):
> Yes, this is all true, but of course I did a diff to current ffprobe code and
> the number of bugfixes is exactly zero.
I did a diff to see if what I suspected was duplicated code was indeed,
and I found it was, and I found failures of synchronization too.
> Strictly speaking, it's not a duplication because one part lives only
> In ffprobe and the other only in ffmpeg.
That is irrelevant, you copy-pasted code, that is code duplication.
> When I had submitted this patchset in 2021, you had said the same
> thing,
Well, unless I was not paying attention, the same flaws lead to the same
comments.
> that you want to work on it, but now it's 4 years later and
> it hasn't happened.
Indeed. “It hasn't happened” is kind of what you should expect when a
prerequisite is being blocked.
> But this can't be a blocker.
You cannot be blocked until the code I had baking is included, but your
code duplication is still a big no, and a big no is blocking.
Regards,
--
Nicolas George
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-02-24 10:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-19 9:59 [FFmpeg-devel] [PATCH 0/3] print_graphs: Complete Filtergraph Printing ffmpegagent
2025-02-19 9:59 ` [FFmpeg-devel] [PATCH 1/3] fftools/ffmpeg_filter: Move some declaration to new header file softworkz
2025-02-19 9:59 ` [FFmpeg-devel] [PATCH 2/3] fftools/ffmpeg_graphprint: Add options for filtergraph printing softworkz
2025-02-21 9:22 ` Andreas Rheinhardt
2025-02-21 9:42 ` Soft Works
2025-02-21 11:11 ` Andreas Rheinhardt
2025-02-21 11:25 ` Soft Works
2025-02-21 13:09 ` Nicolas George
2025-02-21 13:49 ` Soft Works
2025-02-24 10:41 ` Nicolas George [this message]
2025-02-24 13:19 ` Soft Works
2025-02-19 9:59 ` [FFmpeg-devel] [PATCH 3/3] fftools: Enable filtergraph printing and update docs softworkz
2025-02-21 11:27 ` [FFmpeg-devel] [PATCH v2 0/4] print_graphs: Complete Filtergraph Printing ffmpegagent
2025-02-21 11:27 ` [FFmpeg-devel] [PATCH v2 1/4] fftools/ffmpeg_filter: Move some declaration to new header file softworkz
2025-02-21 11:27 ` [FFmpeg-devel] [PATCH v2 2/4] avfilter/avfilter Add avfilter_link_get_hw_frames_ctx() softworkz
2025-02-21 11:27 ` [FFmpeg-devel] [PATCH v2 3/4] fftools/ffmpeg_graphprint: Add options for filtergraph printing softworkz
2025-02-21 11:27 ` [FFmpeg-devel] [PATCH v2 4/4] fftools: Enable filtergraph printing and update docs softworkz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z7xMwa9MvBVhsEEW@phare.normalesup.org \
--to=george@nsup.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git