Re: [FFmpeg-devel] [PATCH] avcodec/v4l2_m2m: Fix segmentation fault due to a missing NULL check in v4l2_context.c

From: Nicolas George <george@nsup.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Eslam Samy <eslamsamy226@yahoo.com>
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/v4l2_m2m: Fix segmentation fault due to a missing NULL check in v4l2_context.c
Date: Tue, 18 Feb 2025 12:27:26 +0100
Message-ID: <Z7RunmOL6eRnp11R@phare.normalesup.org> (raw)
In-Reply-To: <20250218112414.142222-1-eslamsamy226@yahoo.com>

Thanks for the patch.

Eslam Samy via ffmpeg-devel (HE12025-02-18):
> ---
>  libavcodec/v4l2_context.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavcodec/v4l2_context.c b/libavcodec/v4l2_context.c
> index be1df3785b..ea11a689bc 100644
> --- a/libavcodec/v4l2_context.c
> +++ b/libavcodec/v4l2_context.c
> @@ -329,7 +329,7 @@ start:
>          /* if we are trying to get free buffers but none have been queued yet,
>           * or if no buffers have been allocated yet, no need to raise a warning
>           */
> -        if (timeout == 0) {

> +        if ((timeout == 0) && (ctx->buffers != NULL)) {

This does not match ffmpeg's coding style, the extra parentheses and the
!= NULL.

>              if (!ctx->buffers)
>                  return NULL;

Can you explain how this hunk makes sense with your change?

Regards,

-- 
  Nicolas George
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".