From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 693FD4D1D3 for ; Tue, 18 Feb 2025 11:56:14 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 03C0C68BF61; Tue, 18 Feb 2025 13:56:11 +0200 (EET) Received: from nef.ens.fr (nef2.ens.fr [129.199.96.40]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A5F2A68AFFF for ; Tue, 18 Feb 2025 13:56:04 +0200 (EET) X-ENS-nef-client: 129.199.129.80 ( name = phare.normalesup.org ) Received: from phare.normalesup.org (phare.normalesup.org [129.199.129.80]) by nef.ens.fr (8.14.4/1.01.28121999) with ESMTP id 51IBu3nI030276 ; Tue, 18 Feb 2025 12:56:04 +0100 Received: by phare.normalesup.org (Postfix, from userid 1001) id D61412EFDF; Tue, 18 Feb 2025 12:56:03 +0100 (CET) Date: Tue, 18 Feb 2025 12:56:03 +0100 From: Nicolas George To: FFmpeg development discussions and patches Message-ID: References: <20250218112414.142222-1-eslamsamy226.ref@yahoo.com> <20250218112414.142222-1-eslamsamy226@yahoo.com> <1997891029.1068778.1739879208343@mail.yahoo.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1997891029.1068778.1739879208343@mail.yahoo.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (nef.ens.fr [129.199.96.32]); Tue, 18 Feb 2025 12:56:04 +0100 (CET) Subject: Re: [FFmpeg-devel] [PATCH] avcodec/v4l2_m2m: Fix segmentation fault due to a missing NULL check in v4l2_context.c X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Eslam Samy Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Eslam Samy via ffmpeg-devel (HE12025-02-18): > Hi Nicolas, @anchor{What is top-posting?} @section What is top-posting? See @url{https://en.wikipedia.org/wiki/Posting_style#Top-posting}. Instead, use trimmed interleaved/inline replies (@url{https://lists.ffmpeg.org/pipermail/ffmpeg-user/2017-April/035849.html, example}). > The logic behind the change I made is explained here: Ticket #9722. I > tried to fix the issue by adding a null check to prevent the > segmentation fault when ctx->buffers is accessed before being > initialized. Can you confirm that your patch really fixes the issue? You need to confirm you have tested two things: (1) the issue does happen with the current code base and (2) the issue no longer happens with the patch. I strongly suggest you neglected (1). > Regarding the coding style, I reviewed the FFmpeg developer > documentation, but I couldn't find any explicit rules on this matter. > However, I completely understand the importance of adhering to > FFmpeg's coding standards, and I would be happy to modify the patch to > align with the style you suggest. @item No unnecessary parentheses, unless it helps readability: For the rest, you are supposed to imitate the existing code. Feel free to propose adding the rule about null and 0 comparisons. Regards, -- Nicolas George _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".