From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id C24B24D124 for ; Mon, 17 Feb 2025 15:35:34 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 95F0468BE90; Mon, 17 Feb 2025 17:35:30 +0200 (EET) Received: from nef.ens.fr (nef2.ens.fr [129.199.96.40]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3E1B368B5C8 for ; Mon, 17 Feb 2025 17:35:24 +0200 (EET) X-ENS-nef-client: 129.199.129.80 ( name = phare.normalesup.org ) Received: from phare.normalesup.org (phare.normalesup.org [129.199.129.80]) by nef.ens.fr (8.14.4/1.01.28121999) with ESMTP id 51HFZNEU020459 for ; Mon, 17 Feb 2025 16:35:23 +0100 Received: by phare.normalesup.org (Postfix, from userid 1001) id 7E9942EFDF; Mon, 17 Feb 2025 16:35:23 +0100 (CET) Date: Mon, 17 Feb 2025 16:35:23 +0100 From: Nicolas George To: FFmpeg development discussions and patches Message-ID: References: <20250217121741.56025-1-ffmpeg@haasn.xyz> <20250217145317.GD92368@haasn.xyz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250217145317.GD92368@haasn.xyz> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (nef.ens.fr [129.199.96.32]); Mon, 17 Feb 2025 16:35:23 +0100 (CET) Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: add -print_filter_graph option X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Niklas Haas (HE12025-02-17): > For the record, this approach seems to work well - adding a const char *label > to the AVFilterPad struct and then setting it during > avfilter_graph_segment_create_filters() recovers the full label names without > any need for shenanigans. Thanks for looking into it. > That aside, how do you feel about scrapping the current ASCII art > output entirely in favor of the new format? I think that it is, at the > very least, providing just as much information, and IMO more readable. > The ASCII art graph is not really enhancing clarity for me. > > (Though given what Soft Works noted below, it may be a good idea to focus that > version instead) We need at least two formats: one easy to read for humans, one reliable to parse for scripts. Therefore, we need a mechanism to select the format. Under these circumstances, I see no merit in removing the current format; somebody might have built something around it. (Ideally, the computer-readable outputs should offer various formats: JSON, XML, etc. For that, we would need to move into the library with a proper API the code in ffprobe. And for that we need a good strings API. Yet another thing blocked by the people blocking AVWriter.) On the other hand, I do not object to a new format being made the default. Regards, -- Nicolas George _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".