Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Nicolas George <george@nsup.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: add -print_filter_graph option
Date: Mon, 17 Feb 2025 16:35:23 +0100
Message-ID: <Z7NXO5BjjNai1sbj@phare.normalesup.org> (raw)
In-Reply-To: <20250217145317.GD92368@haasn.xyz>

Niklas Haas (HE12025-02-17):
> For the record, this approach seems to work well - adding a const char *label
> to the AVFilterPad struct and then setting it during
> avfilter_graph_segment_create_filters() recovers the full label names without
> any need for shenanigans.

Thanks for looking into it.

> That aside, how do you feel about scrapping the current ASCII art
> output entirely in favor of the new format? I think that it is, at the
> very least, providing just as much information, and IMO more readable.
> The ASCII art graph is not really enhancing clarity for me.
> 
> (Though given what Soft Works noted below, it may be a good idea to focus that
> version instead)

We need at least two formats: one easy to read for humans, one reliable
to parse for scripts. Therefore, we need a mechanism to select the
format. Under these circumstances, I see no merit in removing the
current format; somebody might have built something around it.

(Ideally, the computer-readable outputs should offer various formats:
JSON, XML, etc. For that, we would need to move into the library with a
proper API the code in ffprobe. And for that we need a good strings API.
Yet another thing blocked by the people blocking AVWriter.)

On the other hand, I do not object to a new format being made the
default.

Regards,

-- 
  Nicolas George
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

      reply	other threads:[~2025-02-17 15:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-17 12:17 Niklas Haas
2025-02-17 12:42 ` Nicolas George
2025-02-17 13:40   ` Soft Works
2025-02-17 13:50     ` Niklas Haas
2025-02-17 13:53   ` Niklas Haas
2025-02-17 15:35     ` Nicolas George [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z7NXO5BjjNai1sbj@phare.normalesup.org \
    --to=george@nsup.org \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git