From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTPS id 368FF46C1D
	for <ffmpegdev@gitmailbox.com>; Mon, 27 Jan 2025 18:21:57 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DE55868BC57;
	Mon, 27 Jan 2025 20:21:53 +0200 (EET)
Received: from szaka.eu (szaka.eu [144.217.86.229])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1E08268B615
 for <ffmpeg-devel@ffmpeg.org>; Mon, 27 Jan 2025 20:21:47 +0200 (EET)
Date: Mon, 27 Jan 2025 19:21:37 +0100
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Message-ID: <Z5fOsRclzTEI4JJ0@superpower>
References: <20250124185825.1323-3-ffmpeg@szaka.eu>
 <e3cacca-f91a-c8e6-bcaf-41564c37c11@martin.st>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <e3cacca-f91a-c8e6-bcaf-41564c37c11@martin.st>
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/aarch64/aacencdsp: NEON
 implementation
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
From: Krzysztof Pyrkosz via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Krzysztof Pyrkosz <ffmpeg@szaka.eu>
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/Z5fOsRclzTEI4JJ0@superpower/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

On Sun, Jan 26, 2025 at 01:29:38AM +0200, Martin Storsj=F6 wrote:
> With the following diff:
> =

> @@ -40,8 +41,8 @@ function ff_aac_quant_bands_neon, export=3D1
>          movi            v5.4s, 0x80, lsl #24
>  .irp signed,1,0
>  \signed:
> -        subs            w3, w3, #4
>          ld1             {v3.4s}, [x2], #16
> +        subs            w3, w3, #4
>          fmul            v3.4s, v3.4s, v0.s[0]
>  .if \signed
>          ld1             {v4.4s}, [x1], #16
> =

> I'm getting the following improvement:
> =

> Before:                  Cortex A53      A72      A78
> quant_bands_signed_neon:     5661.0   2383.2   1113.2
> quant_bands_unsigned_neon:   5401.5   2067.8    811.8
> After:
> quant_bands_signed_neon:     5402.5   2385.5   1090.0
> quant_bands_unsigned_neon:   5145.5   2067.8    809.5
> =

> No change on the A72 here, but apparently a (very) small improvement on t=
he
> A78, and a bigger improvement on the A53 as expected.
> =

> If you don't mind these changes, we could land the change with that tweak=
ed.
> (I guess the numbers in the commit message could be re-measured, but I'm =
not
> sure if they change enough to make much of a difference there, especially=
 on
> the cores you've measured on.)
> =

> // Martin

I don't mind these changes, I'm perfectly fine with applying any
improvements on top of the patch.
The speeds on A78 and x13s did not change significantly, the initial
benchmark values can be used.

Krzysztof
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".