From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id BF0C243DE6 for ; Sun, 11 Sep 2022 22:42:19 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id F371C68BB19; Mon, 12 Sep 2022 01:42:16 +0300 (EEST) Received: from mx.sdf.org (mx.sdf.org [205.166.94.24]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 95C2C68B9CB for ; Mon, 12 Sep 2022 01:42:10 +0300 (EEST) Received: from 15fc8db07f19f8c510f57cfd648a18df ([1.136.234.193]) (authenticated (0 bits)) by mx.sdf.org (8.15.2/8.14.5) with ESMTPSA id 28BMg3ab016524 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO) for ; Sun, 11 Sep 2022 22:42:07 GMT Date: Mon, 12 Sep 2022 08:41:59 +1000 From: Peter Ross To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches References: MIME-Version: 1.0 In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 02/18] avcodec/vp8: Disable lf_delta for VP7 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============1610542534941949089==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============1610542534941949089== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="4A5rlikLISXt2IB7" Content-Disposition: inline --4A5rlikLISXt2IB7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Sep 11, 2022 at 06:38:39AM +0200, Andreas Rheinhardt wrote: > Peter Ross: > > On Sat, Sep 10, 2022 at 03:07:13AM +0200, Andreas Rheinhardt wrote: > >> It is a VP8-only feature. > >> > >> Signed-off-by: Andreas Rheinhardt > >> --- > >> libavcodec/vp8.c | 3 +-- > >> 1 file changed, 1 insertion(+), 2 deletions(-) > >> > >> diff --git a/libavcodec/vp8.c b/libavcodec/vp8.c > >> index c00c5c975e..04a2113cc8 100644 > >> --- a/libavcodec/vp8.c > >> +++ b/libavcodec/vp8.c > >> @@ -637,7 +637,6 @@ static int vp7_decode_frame_header(VP8Context *s, = const uint8_t *buf, int buf_si > >> for (i =3D 0; i < 2; i++) > >> memcpy(s->prob->mvc[i], vp7_mv_default_prob[i], > >> sizeof(vp7_mv_default_prob[i])); > >> - memset(&s->lf_delta, 0, sizeof(s->lf_delta)); > >> memcpy(s->prob[0].scan, ff_zigzag_scan, sizeof(s->prob[0].sca= n)); > >> } > >> =20 > >> @@ -2171,7 +2170,7 @@ void filter_level_for_mb(VP8Context *s, VP8Macro= block *mb, > >> } else > >> filter_level =3D s->filter.level; > >> =20 > >> - if (s->lf_delta.enabled) { > >> + if (!is_vp7 && s->lf_delta.enabled) { > >> filter_level +=3D s->lf_delta.ref[mb->ref_frame]; > >> filter_level +=3D s->lf_delta.mode[mb->mode]; > >> } > >=20 > > what's the motivation for patches 01 and 02? > > are you not just adding another condition (is_vp7) to evaluate at decod= e time? > > if its improved readability, then suggest renaming 'lf_delta' to 'lf_de= lta_vp8' > >=20 > > pathces 3-18 look fine to me. > >=20 >=20 > is_vp7 is evaluated at compile-time, because all the functions that use > is_vp7 in this decoder are marked as av_always_inline. > If it were otherwise, several of the patches 3-18 would make no sense > and would just add another runtime check. ok make sense -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) --4A5rlikLISXt2IB7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQSpB+AvpuUM0jTNINJnYHnFrEDdawUCYx5kMwAKCRBnYHnFrEDd a/8fAJ4l9ymnmmNM+QKTgk9u3Oo9zq7MJQCgjo5w0xK2dzK/mhsrAZgTLzZ4bmM= =lmpP -----END PGP SIGNATURE----- --4A5rlikLISXt2IB7-- --===============1610542534941949089== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============1610542534941949089==--